[jira] [Comment Edited] (RATIS-573) Handle Raft Log Append Failure

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866907#comment-16866907 ] 

Tsz Wo Nicholas Sze edited comment on RATIS-573 at 6/18/19 9:33 PM:
--------------------------------------------------------------------

- Using optional in arguments generally is not a good idea; see [https://stackoverflow.com/questions/31922866/why-should-java-8s-optional-not-be-used-in-arguments]
bq. 2. passing LogEntryProto as a Optional to notifyLogFailed().
 Just pass null when LogEntryProto is unavailable.

- Why add isSync()?
{code}
+      if ((stateMachineFuture == null) ||
+          (stateMachineDataPolicy.isSync())) {
{code}


 


was (Author: szetszwo):
> 2. passing LogEntryProto as a Optional to notifyLogFailed().

Using optional in arguments generally is not a good idea; see [https://stackoverflow.com/questions/31922866/why-should-java-8s-optional-not-be-used-in-arguments]
 Just pass null when LogEntryProto is unavailable.

> Why add isSync()?
{code}
+      if ((stateMachineFuture == null) ||
+          (stateMachineDataPolicy.isSync())) {
{code}


 

> Handle Raft Log Append Failure
> ------------------------------
>
>                 Key: RATIS-573
>                 URL: https://issues.apache.org/jira/browse/RATIS-573
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>            Reporter: Supratim Deka
>            Assignee: Supratim Deka
>            Priority: Major
>         Attachments: RATIS-573.00.patch, RATIS-573.01.patch, RATIS-573.02.patch
>
>
> As part of Handling IO Failures, HDDS-1595.
> The scope of this jira is to handle failure in RAFT log append by:
> 1. notify the error to the state machine for consumer specific handling
> 2. propagate the error to the initiator (to the client from leader, to the leader from follower).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)