[GitHub] [skywalking-go] wu-sheng commented on a diff in pull request #81: Support enhance native `mutex` as plugin

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #81:
URL: https://github.com/apache/skywalking-go/pull/81#discussion_r1270188085


##########
CHANGES.md:
##########
@@ -22,6 +22,7 @@ Release Notes.
 * Support [Native SQL](https://pkg.go.dev/net/http) database client framework with [MySQL Driver](github.com/go-sql-driver/mysql).
 * Support [Logrus](https://github.com/sirupsen/logrus) log report to the backend.
 * Support [Zap](https://github.com/uber-go/zap) log report to the backend.
+* Support [Native Mutex](https://pkg.go.dev/sync) lock client framework.

Review Comment:
   Also, you only support tracing, but not logic endpoint or metric of lock(pending, release, etc.).
   Should we consider that?



##########
CHANGES.md:
##########
@@ -22,6 +22,7 @@ Release Notes.
 * Support [Native SQL](https://pkg.go.dev/net/http) database client framework with [MySQL Driver](github.com/go-sql-driver/mysql).
 * Support [Logrus](https://github.com/sirupsen/logrus) log report to the backend.
 * Support [Zap](https://github.com/uber-go/zap) log report to the backend.
+* Support [Native Mutex](https://pkg.go.dev/sync) lock client framework.

Review Comment:
   ```suggestion
   * Support [Native Mutex](https://pkg.go.dev/sync) lock client framework.
   ```
   
   Lock client? Is it a distributed lock solution as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org