You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/12/20 02:05:23 UTC
[jclouds] JCLOUDS-391: Azure multipart putBlob user metadata (#628)
You can merge this Pull Request by running:
git pull https://github.com/andrewgaul/jclouds azure-multipart-usermetadata
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/628
-- Commit Summary --
* JCLOUDS-391: Azure multipart putBlob user metadata
-- File Changes --
M providers/azureblob/src/main/java/org/jclouds/azureblob/AzureBlobClient.java (18)
A providers/azureblob/src/main/java/org/jclouds/azureblob/binders/BindAzureBlobMetadataToMultipartRequest.java (55)
M providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/strategy/AzureBlobBlockUploadStrategy.java (7)
M providers/azureblob/src/test/java/org/jclouds/azureblob/blobstore/integration/AzureBlobIntegrationLiveTest.java (26)
M providers/azureblob/src/test/java/org/jclouds/azureblob/blobstore/strategy/AzureBlobBlockUploadStrategyTest.java (10)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/628.patch
https://github.com/jclouds/jclouds/pull/628.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628
Re: [jclouds] JCLOUDS-391: Azure multipart putBlob user metadata
(#628)
Posted by Ignasi Barrera <no...@github.com>.
> +import javax.inject.Singleton;
> +
> +import org.jclouds.azureblob.blobstore.functions.AzureBlobToBlob;
> +import org.jclouds.azureblob.domain.AzureBlob;
> +import org.jclouds.blobstore.binders.BindUserMetadataToHeadersWithPrefix;
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.rest.Binder;
> +
> +@Singleton
> +public class BindAzureBlobMetadataToMultipartRequest implements Binder {
> +
> + private final AzureBlobToBlob azureBlob2Blob;
> + private final BindUserMetadataToHeadersWithPrefix blobBinder;
> +
> + @Inject
> + public BindAzureBlobMetadataToMultipartRequest(AzureBlobToBlob azureBlob2Blob, BindUserMetadataToHeadersWithPrefix blobBinder) {
Change signature to package private, so only the Guice injector (and test classes) can directly instantiate the class. Then we can remove the redundant null checks?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628/files#r22191446
Re: [jclouds] JCLOUDS-391: Azure multipart putBlob user metadata
(#628)
Posted by Andrew Gaul <no...@github.com>.
> +import javax.inject.Singleton;
> +
> +import org.jclouds.azureblob.blobstore.functions.AzureBlobToBlob;
> +import org.jclouds.azureblob.domain.AzureBlob;
> +import org.jclouds.blobstore.binders.BindUserMetadataToHeadersWithPrefix;
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.rest.Binder;
> +
> +@Singleton
> +public class BindAzureBlobMetadataToMultipartRequest implements Binder {
> +
> + private final AzureBlobToBlob azureBlob2Blob;
> + private final BindUserMetadataToHeadersWithPrefix blobBinder;
> +
> + @Inject
> + public BindAzureBlobMetadataToMultipartRequest(AzureBlobToBlob azureBlob2Blob, BindUserMetadataToHeadersWithPrefix blobBinder) {
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628/files#r22192823
Re: [jclouds] JCLOUDS-391: Azure multipart putBlob user metadata
(#628)
Posted by Ignasi Barrera <no...@github.com>.
>
> @Inject
> - public AzureBlobBlockUploadStrategy(AzureBlobClient client, PayloadSlicer slicer) {
> + public AzureBlobBlockUploadStrategy(AzureBlobClient client, PayloadSlicer slicer, BlobToAzureBlob blobToAzureBlob) {
I know this was already public, but make package private?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628/files#r22191496
Re: [jclouds] JCLOUDS-391: Azure multipart putBlob user metadata
(#628)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master as 1c781cc5fa79ab2f476ec07600f493bd04940cc3.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628#issuecomment-67908059
Re: [jclouds] JCLOUDS-391: Azure multipart putBlob user metadata
(#628)
Posted by Andrew Gaul <no...@github.com>.
> + */
> +package org.jclouds.azureblob.binders;
> +
> +import static com.google.common.base.Preconditions.checkArgument;
> +import static com.google.common.base.Preconditions.checkNotNull;
> +
> +import javax.inject.Inject;
> +import javax.inject.Singleton;
> +
> +import org.jclouds.azureblob.blobstore.functions.AzureBlobToBlob;
> +import org.jclouds.azureblob.domain.AzureBlob;
> +import org.jclouds.blobstore.binders.BindUserMetadataToHeadersWithPrefix;
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.rest.Binder;
> +
> +@Singleton
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628/files#r22192934
Re: [jclouds] JCLOUDS-391: Azure multipart putBlob user metadata
(#628)
Posted by Ignasi Barrera <no...@github.com>.
> + */
> +package org.jclouds.azureblob.binders;
> +
> +import static com.google.common.base.Preconditions.checkArgument;
> +import static com.google.common.base.Preconditions.checkNotNull;
> +
> +import javax.inject.Inject;
> +import javax.inject.Singleton;
> +
> +import org.jclouds.azureblob.blobstore.functions.AzureBlobToBlob;
> +import org.jclouds.azureblob.domain.AzureBlob;
> +import org.jclouds.blobstore.binders.BindUserMetadataToHeadersWithPrefix;
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.rest.Binder;
> +
> +@Singleton
Do we really this to be singleton? (Is its use that common?) Or can just we ask Guice to instantiate it when the method is called?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628/files#r22191412
Re: [jclouds] JCLOUDS-391: Azure multipart putBlob user metadata
(#628)
Posted by Andrew Gaul <no...@github.com>.
>
> @Inject
> - public AzureBlobBlockUploadStrategy(AzureBlobClient client, PayloadSlicer slicer) {
> + public AzureBlobBlockUploadStrategy(AzureBlobClient client, PayloadSlicer slicer, BlobToAzureBlob blobToAzureBlob) {
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/628/files#r22192827