You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/10/25 16:00:20 UTC

[PR] Refactor CDC sinks into SPI, core and socket modules [shardingsphere]

terrymanu opened a new pull request, #40366:
URL: https://github.com/apache/shardingsphere/pull/40366

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor CDC sinks into SPI, core and socket modules [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40366:
URL: https://github.com/apache/shardingsphere/pull/40366


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor CDC sinks into SPI, core and socket modules [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40366:
URL: https://github.com/apache/shardingsphere/pull/40366#issuecomment-6406814908

   ### Result
   Review Result: Mergeable
   No required changes remain within this scope and design-necessity review.
   
   ### Evidence
   - The factory, failure capability, and creation contexts implement explicitly required module boundaries.
   - CDCRecordPreparer owns actual schema-mapping state and record-processing behavior.
   - The ACK entry point preserves core ownership without extending acknowledgment semantics.
   - Failure handling preserves the original error and necessary cleanup without introducing a lifecycle framework.
   - Remaining tests and dependencies have corresponding scenarios or actual consumers.
   - No unrelated Kafka, commercial, protocol, or client extensions were found.
   
   ### Coverage
   Reviewed all 39 changed files and 93 change blocks.
   Completed two independent reviews, three review perspectives,
   and a coordinated convergence check.
   Spotless covered 29 Java files and 9 POMs;
   Checkstyle covered all 29 Java files. Both passed.
   CI was not reviewed. No code was modified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org