You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "alexio215 (via GitHub)" <gi...@apache.org> on 2025/03/04 22:35:35 UTC

[PR] HTTP SSL proxy option [airflow]

alexio215 opened a new pull request, #47362:
URL: https://github.com/apache/airflow/pull/47362

   **Depends On:**
   pyHive [release v1.11.0](https://github.com/apache/kyuubi/milestone/42)
   pyHive from Kyuubi is may not yet be released on PyPi investigating.
   
   Purpose:
   Needed to have secure mTLS communication with an NGINX reverse proxy serving incoming HTTP wrapped Thrift traffic to a HiveServer2 instance.
   
   Context:
   In the new version of pyHive, now adopted by the Apache Kyuubi project, the latest merge to master, awaiting next release, ssl_context is now a parameter that can be passed into the connection object. This allows a user to create their own ssl_context, rather than passing in individual parameters to create one.
   
   Change:
   HiveServer2Hook--> get_conn:
   - if scheme == https, ssl context is created  and looks for as many options as it can, first enabling TLS, and mTLS is client cert and key are provided.
   HiveMetastoreHook--> get_metastore_client:
   - if use_http_proxy, thrift traffic is wrapped in HTTP using THTTPClient. Looks progressively to build ssl_context, first for TLS, and then mTLS is provided. Wraps transport layer in HTTP, otherwise continues to use existing behavior.
   Pre-Commit added files:
   Pre-Commit added files to commit, those have been included.
   
   Testing:
   Added all tests to match new behavior, as well as edited old tests to expect new default parameter in the upcoming pyHive update, which defaults to `None`.
   
   Comments:
   Still very new to contributing, happy to abide and comply with requests and rules.
   
   Issue:
   [#46023 ](https://github.com/apache/airflow/issues/46023)
   @nevcohen 
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HTTP SSL proxy option [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47362:
URL: https://github.com/apache/airflow/pull/47362#issuecomment-2816385635

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HTTP SSL proxy option [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #47362: HTTP SSL proxy option
URL: https://github.com/apache/airflow/pull/47362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HTTP SSL proxy option [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #47362:
URL: https://github.com/apache/airflow/pull/47362#issuecomment-2699131814

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org