You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by fe...@apache.org on 2016/03/14 20:58:46 UTC
incubator-zeppelin git commit: Fix Selenium test url
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master 7e932e944 -> 848f4fba6
Fix Selenium test url
### What is this PR for?
use env variable `url` instead of system property
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* ZEPPELIN-729
### How should this be tested?
Change the domain name or port and set a new env variable called `url` with the new url
Author: Renjith Kamath <re...@gmail.com>
Closes #771 from r-kamath/fixSeleniumTestUrl and squashes the following commits:
de76168 [Renjith Kamath] Fix Selenium test url
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/848f4fba
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/848f4fba
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/848f4fba
Branch: refs/heads/master
Commit: 848f4fba662df8cf81a0b3b4667b49190c864c79
Parents: 7e932e9
Author: Renjith Kamath <re...@gmail.com>
Authored: Wed Mar 9 17:30:13 2016 +0530
Committer: Felix Cheung <fe...@apache.org>
Committed: Mon Mar 14 12:58:42 2016 -0700
----------------------------------------------------------------------
.../src/test/java/org/apache/zeppelin/WebDriverManager.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/848f4fba/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java b/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
index 917896f..2a1f58b 100644
--- a/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
+++ b/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
@@ -106,8 +106,8 @@ public class WebDriverManager {
}
String url;
- if (System.getProperty("url") != null) {
- url = System.getProperty("url");
+ if (System.getenv("url") != null) {
+ url = System.getenv("url");
} else {
url = "http://localhost:8080";
}