[jira] [Commented] (NIFI-4836) Allow QueryDatabaseTables to send out batches of flow files while result set is being processed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348725#comment-16348725 ] 

ASF GitHub Bot commented on NIFI-4836:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2447

    NIFI-4836: Allow output of FlowFiles during result set processing in QueryDatabaseTable

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4836

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2447
    
----
commit f4d3e60b5cb0183b6e077680e26ce69e5be584ad
Author: Matthew Burgess <ma...@...>
Date:   2018-02-01T15:08:09Z

    NIFI-4836: Allow output of FlowFiles during result set processing in QueryDatabaseTable

----


> Allow QueryDatabaseTables to send out batches of flow files while result set is being processed
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4836
>                 URL: https://issues.apache.org/jira/browse/NIFI-4836
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> Currently QueryDatabaseTable (QDT) will not transfer the outgoing flowfiles to the downstream relationship(s) until the entire result set has been processed (regardless of whether Max Rows Per Flow File is set). This is so the maxvalue.* and fragment.count attributes can be set correctly for each flow file.
> However for very large result sets, the initial fetch can take a long time, and depending on the setting of Max Rows Per FlowFile, there could be a great number of FlowFiles transferred downstream as a large burst at the end of QDT execution.
> It would be nice for the user to be able to choose to have FlowFiles be transferred downstream while the result set is still being processed. This alleviates the "large burst at the end" by replacing it with smaller output batches during processing. The tradeoff will be that if an Output Batch Size is set, then the maxvalue.* and fragment.count attributes will not be set on the outgoing flow files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)