You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/01 12:24:55 UTC

[GitHub] [pulsar] WJL3333 commented on a diff in pull request #18278: [cleanup][broker] Get lowest PositionImpl from NavigableSet

WJL3333 commented on code in PR #18278:
URL: https://github.com/apache/pulsar/pull/18278#discussion_r1010368065


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -285,7 +286,7 @@ public synchronized void readMoreEntries() {
                 }
 
                 havePendingReplayRead = true;
-                minReplayedPosition = messagesToReplayNow.stream().min(PositionImpl::compareTo).orElse(null);
+                minReplayedPosition = messagesToReplayNow.pollFirst();

Review Comment:
   fixed, thanks for review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org