You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/09/25 14:01:39 UTC
Review Request: FLUME-1607: FileChannel We should use a regex as opposed to
simple filename filter when finding logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7252/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Implements FLUME-1607
This addresses bug FLUME-1607.
https://issues.apache.org/jira/browse/FLUME-1607
Diffs
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java 32ebac7
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java c14a6f0
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java ad2a645
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 68285cc
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java e3eb184
Diff: https://reviews.apache.org/r/7252/diff/
Testing
-------
Adds two tests for new method. One unit test and one testing replay with extra files.
Thanks,
Brock Noland
Re: Review Request: FLUME-1607: FileChannel We should use a regex as opposed
to simple filename filter when finding logs
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7252/#review11914
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On Sept. 25, 2012, 2:23 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7252/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2012, 2:23 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Implements FLUME-1607
>
>
> This addresses bug FLUME-1607.
> https://issues.apache.org/jira/browse/FLUME-1607
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java 32ebac7
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java c14a6f0
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java ad2a645
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 68285cc
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java e3eb184
>
> Diff: https://reviews.apache.org/r/7252/diff/
>
>
> Testing
> -------
>
> Adds two tests for new method. One unit test and one testing replay with extra files.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1607: FileChannel We should use a regex as opposed
to simple filename filter when finding logs
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7252/
-----------------------------------------------------------
(Updated Sept. 25, 2012, 2:23 p.m.)
Review request for Flume.
Changes
-------
Updates the regex to match the entire filename and adds more files to testGetLogs.
Description
-------
Implements FLUME-1607
This addresses bug FLUME-1607.
https://issues.apache.org/jira/browse/FLUME-1607
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java 32ebac7
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java c14a6f0
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java ad2a645
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 68285cc
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java e3eb184
Diff: https://reviews.apache.org/r/7252/diff/
Testing
-------
Adds two tests for new method. One unit test and one testing replay with extra files.
Thanks,
Brock Noland