[GitHub] bigtop pull request #193: BIGTOP-2734. Enhancements to ODPi runtime certific...

[rvs <gi...@git.apache.org>]

Github user rvs commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/193#discussion_r121272401
  
    --- Diff: bigtop-tests/smoke-tests/run_itest.sh ---
    @@ -262,16 +326,23 @@ echo "# Use --debug/--info for more details"
     if [ -z "$ITESTS" ]; then
       export ITESTS="hive,hcfs,hdfs,yarn,mapreduce,odpi-runtime"
     fi
    -for s in `echo $ITESTS | sed -e 's#,# #g'`; do
    -  ALL_SMOKE_TASKS="$ALL_SMOKE_TASKS bigtop-tests:smoke-tests:$s:test"
    -done
     
     if echo "$ITESTS" | egrep -q 'hive|odpi-runtime' ; then
       set_hive_vars
     fi 
     
     # CALL THE GRADLE WRAPPER TO RUN THE FRAMEWORK
    -$DIR/gradlew -q --continue clean -Psmoke.tests $TEST_SETTINGS $ALL_SMOKE_TASKS $LOGGING
    +if [ -f $DIR/gradlew ]; then
    +  for s in `echo $ITESTS | sed -e 's#,# #g'`; do
    +    ALL_SMOKE_TASKS="$ALL_SMOKE_TASKS bigtop-tests:smoke-tests:$s:test"
    +  done
    +  $DIR/gradlew -q --continue clean -Psmoke.tests $TEST_SETTINGS $ALL_SMOKE_TASKS $LOGGING
    +elif [ -f $DIR/../../gradlew ]; then
    +  for s in `echo $ITESTS | sed -e 's#,# #g'`; do
    +    ALL_SMOKE_TASKS="$ALL_SMOKE_TASKS $s:test"
    +  done
    +  $DIR/../../gradlew -q --continue clean -Psmoke.tests $TEST_SETTINGS $ALL_SMOKE_TASKS $LOGGING
    +fi
     
    --- End diff --
    
    Also, I'm not quite sure why this duplication of logic. What am I missing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---