You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/28 10:27:25 UTC
[GitHub] [incubator-linkis] WenxiangFan opened a new pull request, #2359: Add knife4j by a new module named linkis-knif4j
WenxiangFan opened a new pull request, #2359:
URL: https://github.com/apache/incubator-linkis/pull/2359
### What is the purpose of the change
Add knife4j by a new module
### Brief change log
-Create a new module named linikis-knif4j
-Add the dependency of the linikis-knif4j module in “assembly-combined-package/assembly-combined/public-module-combined/pom.xml”
-Linikis-knif4j will be packaged in the "lib/links-commons/public-module/" path.
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) yes
- Anything that affects deployment: (yes / no / don't know) no
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no) no
### Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] WenxiangFan closed pull request #2359: Add knife4j by a new module named linkis-knif4j
Posted by GitBox <gi...@apache.org>.
WenxiangFan closed pull request #2359: Add knife4j by a new module named linkis-knif4j
URL: https://github.com/apache/incubator-linkis/pull/2359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] WenxiangFan commented on pull request #2359: Add knife4j by a new module named linkis-knif4j
Posted by GitBox <gi...@apache.org>.
WenxiangFan commented on PR #2359:
URL: https://github.com/apache/incubator-linkis/pull/2359#issuecomment-1169489891
Code has been modified, please resubmit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] WenxiangFan commented on pull request #2359: Add knife4j by a new module named linkis-knif4j
Posted by GitBox <gi...@apache.org>.
WenxiangFan commented on PR #2359:
URL: https://github.com/apache/incubator-linkis/pull/2359#issuecomment-1169746085
Close this pull request and resubmit a new one。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org