You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/28 19:54:46 UTC

[GitHub] [flink] sjwiesman commented on a change in pull request #13912: [FLINK-19466][FLINK-19467][runtime / state backends] Add Flip-142 public interfaces and methods

sjwiesman commented on a change in pull request #13912:
URL: https://github.com/apache/flink/pull/13912#discussion_r566367763



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageLoader.java
##########
@@ -84,12 +88,23 @@
 
         switch (storageName.toLowerCase()) {
             case JOB_MANAGER_STORAGE_NAME:
-                throw new UnsupportedOperationException(
-                        "JobManagerCheckpointStorage is not yet implemented");
+                if (logger != null) {

Review comment:
       I copied this pattern from StateBackendLoader without checking why. Let me see if there's a good reason for it, otherwise +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org