You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/06/11 16:12:21 UTC
[royale-asjs] branch develop updated:
ClassSelectorListHoverOnlySelectableItemRendererBead: make it truly only
for "hovered",
so overriding "selected" and "down" states to do anything and avoid this way
run updateRenderer method and maintain its private var undefined
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 1975a0f ClassSelectorListHoverOnlySelectableItemRendererBead: make it truly only for "hovered", so overriding "selected" and "down" states to do anything and avoid this way run updateRenderer method and maintain its private var undefined
1975a0f is described below
commit 1975a0ffdc359658bbac9c26a185f87c5e7c243c
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Thu Jun 11 18:12:12 2020 +0200
ClassSelectorListHoverOnlySelectableItemRendererBead: make it truly only for "hovered", so overriding "selected" and "down" states to do anything and avoid this way run updateRenderer method and maintain its private var undefined
---
frameworks/projects/Jewel/src/main/resources/defaults.css | 2 +-
...ClassSelectorListHoverOnlySelectableItemRendererBead.as | 14 ++++++++++++--
.../Jewel/src/main/sass/components/_itemRenderer.sass | 2 +-
3 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/resources/defaults.css b/frameworks/projects/Jewel/src/main/resources/defaults.css
index 34f96d4..47e46d1 100644
--- a/frameworks/projects/Jewel/src/main/resources/defaults.css
+++ b/frameworks/projects/Jewel/src/main/resources/defaults.css
@@ -998,7 +998,7 @@ j|ImageButton {
position: relative;
list-style: none;
}
-.jewel.item.selectable, .jewel.navigationlink.selectable, .jewel.tabbarbutton.selectable {
+.jewel.item.selectable, .jewel.item.hoverable, .jewel.navigationlink.selectable, .jewel.navigationlink.hoverable, .jewel.tabbarbutton.selectable, .jewel.tabbarbutton.hoverable {
cursor: pointer;
}
.jewel.item .fonticon, .jewel.navigationlink .fonticon, .jewel.tabbarbutton .fonticon {
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/ClassSelectorListHoverOnlySelectableItemRendererBead.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/ClassSelectorListHoverOnlySelectableItemRendererBead.as
index cf5a99a..ac818c1 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/ClassSelectorListHoverOnlySelectableItemRendererBead.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/ClassSelectorListHoverOnlySelectableItemRendererBead.as
@@ -23,7 +23,7 @@ package org.apache.royale.jewel.beads.itemRenderers
import org.apache.royale.utils.IClassSelectorListSupport;
/**
- * UnselectableElement bead prevents from text selection of html element
+ * UnselectableElement bead prevents selection but can be hovered
*
* @viewbead
* @langversion 3.0
@@ -51,9 +51,19 @@ package org.apache.royale.jewel.beads.itemRenderers
{
super.strand = value;
ir = value as IClassSelectorListSupport;
- ir.addClass("selectable");
+ ir.addClass("hoverable");
}
+ override public function set selected(value:Boolean):void
+ {
+ // this renderer is not selectable, so don't do anything
+ }
+
+ override public function set down(value:Boolean):void
+ {
+ // this renderer is not selectable, so don't do anything
+ }
+
/**
* @private
*/
diff --git a/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass b/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass
index b3058a9..ba1f041 100644
--- a/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass
+++ b/frameworks/projects/Jewel/src/main/sass/components/_itemRenderer.sass
@@ -37,7 +37,7 @@ $item-min-height: 34px
position: relative
list-style: none
- &.selectable
+ &.selectable, &.hoverable
cursor: pointer
// pointer-events: auto