You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2023/01/20 04:06:57 UTC
[GitHub] [gobblin] phet opened a new pull request, #3627: Specifically name each Hikari connection pool created, for traceability
phet opened a new pull request, #3627:
URL: https://github.com/apache/gobblin/pull/3627
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1753
Specifically name each Hikari connection pool created, for traceability
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
since stores are independently configurable, and it's possible for each to use a different DB, we expect a connection pool per store (even when several may physically utilize the same DB as each other). To discern which store has created which pool, this change has each datasource (pool) provider name the pool after itself. in the absence of explicitly specifying a pool name all would be given a monotonically increasing name, like `HikariPool-##`. that unfortunately gives no indication of which pool relates to which store. Knowing that may aid in diagnosing whether a given store provider has created more pools than anticipated, as typically there should be only one per store.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
existing tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3627: Specifically name each Hikari connection pool created, for traceability
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3627:
URL: https://github.com/apache/gobblin/pull/3627#issuecomment-1397906097
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3627](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b377106) into [master](https://codecov.io/gh/apache/gobblin/commit/85cd1f9875ba64bd059b70a4d5fc40a38383d326?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85cd1f9) will **decrease** coverage by `2.64%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## master #3627 +/- ##
============================================
- Coverage 46.44% 43.81% -2.64%
+ Complexity 10621 2063 -8558
============================================
Files 2130 409 -1721
Lines 83303 17639 -65664
Branches 9282 2152 -7130
============================================
- Hits 38692 7728 -30964
+ Misses 41039 9053 -31986
+ Partials 3572 858 -2714
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/gobblin/util/jdbc/DataSourceProvider.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvamRiYy9EYXRhU291cmNlUHJvdmlkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `10.54% <80.00%> (+2.44%)` | :arrow_up: |
| [...obblin/metastore/JobHistoryDataSourceProvider.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0pvYkhpc3RvcnlEYXRhU291cmNlUHJvdmlkZXIuamF2YQ==) | `66.66% <100.00%> (+4.16%)` | :arrow_up: |
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | | |
| [...a/org/apache/gobblin/source/jdbc/JdbcProvider.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL0pkYmNQcm92aWRlci5qYXZh) | | |
| [...ervice/modules/db/ServiceDatabaseProviderImpl.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYi9TZXJ2aWNlRGF0YWJhc2VQcm92aWRlckltcGwuamF2YQ==) | | |
| [...in/java/org/apache/gobblin/r2/R2ClientFactory.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9yMi9SMkNsaWVudEZhY3RvcnkuamF2YQ==) | | |
| [...ompaction/mapreduce/RecordKeyDedupReducerBase.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL1JlY29yZEtleURlZHVwUmVkdWNlckJhc2UuamF2YQ==) | | |
| [...management/partition/CopyableDatasetRequestor.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BhcnRpdGlvbi9Db3B5YWJsZURhdGFzZXRSZXF1ZXN0b3IuamF2YQ==) | | |
| [.../extractor/hadoop/OldApiWritableFileExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvaGFkb29wL09sZEFwaVdyaXRhYmxlRmlsZUV4dHJhY3Rvci5qYXZh) | | |
| ... and [1716 more](https://codecov.io/gh/apache/gobblin/pull/3627?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3627: Specifically name each Hikari connection pool created, for traceability
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo commented on code in PR #3627:
URL: https://github.com/apache/gobblin/pull/3627#discussion_r1083096502
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -74,7 +74,7 @@ public class ConfigurationKeys {
public static final boolean DEFAULT_STATE_STORE_COMPRESSED_VALUES = true;
// DB state store configuration
public static final String STATE_STORE_DB_JDBC_DRIVER_KEY = "state.store.db.jdbc.driver";
- public static final String DEFAULT_STATE_STORE_DB_JDBC_DRIVER = "com.mysql.jdbc.Driver";
Review Comment:
Is this branch not built off master? The diffs seem off since this was committed by you in a prior PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] phet commented on a diff in pull request #3627: Specifically name each Hikari connection pool created, for traceability
Posted by "phet (via GitHub)" <gi...@apache.org>.
phet commented on code in PR #3627:
URL: https://github.com/apache/gobblin/pull/3627#discussion_r1083143470
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -74,7 +74,7 @@ public class ConfigurationKeys {
public static final boolean DEFAULT_STATE_STORE_COMPRESSED_VALUES = true;
// DB state store configuration
public static final String STATE_STORE_DB_JDBC_DRIVER_KEY = "state.store.db.jdbc.driver";
- public static final String DEFAULT_STATE_STORE_DB_JDBC_DRIVER = "com.mysql.jdbc.Driver";
Review Comment:
sorry those may have landed while this was under development... now fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3627: Specifically name each Hikari connection pool created, for traceability
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3627:
URL: https://github.com/apache/gobblin/pull/3627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org