You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/30 17:58:18 UTC
[GitHub] [tvm] mbs-octoml opened a new pull request #9613: [DRAFT][Relay] PlanDevices pass can run after LowerTE pass
mbs-octoml opened a new pull request #9613:
URL: https://github.com/apache/tvm/pull/9613
** Not ready for review. **
This allows PlanDevices to run both pre- and post-lowering. It also looks for memory scopes on PrimFunc inputs and outputs (iif non-empty) and incorporates them into the existing SEScope constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on a change in pull request #9613: [Relay] Re-run PlanDevices after LowerTE to flow new memory scope constraints.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #9613:
URL: https://github.com/apache/tvm/pull/9613#discussion_r768066039
##########
File path: include/tvm/relay/expr.h
##########
@@ -234,6 +234,15 @@ class Var : public Expr {
*/
TVM_DLL Var(Id vid, Type type_annotation, Span span = Span());
+ /*!
+ * \brief Return a globally fresh name. Helps with debugging to follow the same
+ * variable between passes and sub-expressions.
+ *
+ * TODO(mbs): Replace with name creation w.r.t. scopes once available as part of
+ * name gen overhaul.
+ */
+ static Var GenSym(Type type_annotation = {}, Span span = {});
Review comment:
Is this mutex'd?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on a change in pull request #9613: [Relay] Re-run PlanDevices after LowerTE to flow new memory scope constraints.
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on a change in pull request #9613:
URL: https://github.com/apache/tvm/pull/9613#discussion_r768182812
##########
File path: include/tvm/relay/expr.h
##########
@@ -234,6 +234,15 @@ class Var : public Expr {
*/
TVM_DLL Var(Id vid, Type type_annotation, Span span = Span());
+ /*!
+ * \brief Return a globally fresh name. Helps with debugging to follow the same
+ * variable between passes and sub-expressions.
+ *
+ * TODO(mbs): Replace with name creation w.r.t. scopes once available as part of
+ * name gen overhaul.
+ */
+ static Var GenSym(Type type_annotation = {}, Span span = {});
Review comment:
Guessing by the question it needs to be. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #9613: [Relay] Re-run PlanDevices after LowerTE to flow new memory scope constraints.
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #9613:
URL: https://github.com/apache/tvm/pull/9613#issuecomment-993851060
Thanks @mbs-octoml @jroesch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #9613: [Relay] Re-run PlanDevices after LowerTE to flow new memory scope constraints.
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #9613:
URL: https://github.com/apache/tvm/pull/9613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org