You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Joel Orlina (JIRA)" <ji...@codehaus.org> on 2012/06/26 19:45:21 UTC
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Joel Orlina created MRELEASE-777:
------------------------------------
Summary: release plugin shouldn't git clone if the SCM is git
Key: MRELEASE-777
URL: https://jira.codehaus.org/browse/MRELEASE-777
Project: Maven 2.x Release Plugin
Issue Type: Improvement
Environment: Linux x86_64, maven 2.2.1
Reporter: Joel Orlina
See here for original issue:
https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317646#comment-317646 ]
Mark Struberg commented on MRELEASE-777:
----------------------------------------
yes, looks you don't do a localCheckout at all somehow. You should get a file:// URL.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317645#comment-317645 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
I understand local clones, but the m-rel-p output in question is this:
[INFO] Executing: /bin/sh -c cd /home/fg/src/json-schema-validator/target && git clone git@github.com:fge/json-schema-validator /home/fg/src/json-schema-validator/target/checkout
That ain't using hard links ;-) Maybe it's from an old plugin version?
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317644#comment-317644 ]
Mark Struberg commented on MRELEASE-777:
----------------------------------------
being a GIT user/contributor since 2006 I can tell you that GIT is smart enough to _not_ copy files over. Instead GIT automatically does only reference the local origin repo without copying any files. So this really is the best option, because this is the only one which is really portable.
please check the -l option man git-clone
We explicitely don't use git-clone -s as we cannot guarantee that a user doesn't do any weirdo stuff in the cloned repo which would break upstream...
Also consider that the maven-release-manager simply does a 'scm checkout' on all SCMs. Thus in order to remain portable we just provided the local file:// URL which is known to work with all distributed SCMs without having to do some special hacks.
A local git-clone of a 4GB git repo takes way sub-second... I really see no reason to further improve this.
PS: being busy with a big refactoring in Apache OpenWebBeans atm, hope to be back working on the incremental and SCM stuff in about 2 weeks.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319929#comment-319929 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
Your usecase is just one. I have ignored pngs/ and tmp/ which devs are allowed/encouraged to put their screenies, WIPs and other random files in. Running git clean -dfx destroys everything, which is a BIG surprise and VERY unwelcome as a default. It's a maven build, maven clean should be sfufficient. If it is not, there are project structure problems to resolve (build output outside of target/).
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317643#comment-317643 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
Hi Mark! I saw those options, however IMO the clone concept is completely and utterly broken. You already have the repo with a checkout, and the POM from that, in order to even think about doing a release. You also already have the entire history already already, because we're talking Git, not dinosaur stuff ;-) so if you want to do a clone at all, which is brain dead, even locally, then you'd do it from the existing repo. If you don't want to do a clone, and I assure you, you definitely do not ever want to do that, then you simply set GIT_DIR and GIT_WORK_TREE and do a checkout of a hash. Simple as that. Long time no see, too :-)
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Anatoly Kupriyanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319896#comment-319896 ]
Anatoly Kupriyanov commented on MRELEASE-777:
---------------------------------------------
I have a project which has several thousand files in it. So even hardlinks don't do the job significantly faster. And there is no way to tell the plugin to pull changes instead of cloning them. As I see in the source code, the release plugin v2.4 deletes the checkout directory first (CheckoutProjectFromScm.java:199), and it means that clone will be commenced always. The "git clean" should be used to create an clean copy to build.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Anatoly Kupriyanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319925#comment-319925 ]
Anatoly Kupriyanov commented on MRELEASE-777:
---------------------------------------------
It is absolutely unnecessary for git. Until the commit is pushed outside, it is very easy to rollback with "git reset". In my case the build runs a lot of integration tests which take nearly 20 minutes. It is not so good to run it twice.
I am talking about the [workingDirectory|http://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html#workingDirectory], at the moment the plugin just deletes the folder. It makes even safer to do "git clean" instead.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317638#comment-317638 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
A telling link from Robert, for context here: http://maven.apache.org/scm/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/xref/org/apache/maven/scm/provider/git/gitexe/command/checkout/GitCheckOutCommand.html Thanks!
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Anatoly Kupriyanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319905#comment-319905 ]
Anatoly Kupriyanov commented on MRELEASE-777:
---------------------------------------------
The release plugin does a lot strange things which ruin the performance. At the moment it creates a clone of wc, it build the project twice, it pollutes the wc with temporary files. Maybe it has a sense for some SCMs, but obviously not for git.
For git the workflow should be:
1. Check local modifications, fail if any.
2. git clean -xdf
3. Set next version number
4. Commit
5. Create tag
6. mvn deploy
7. Make a snapshot version number
8. Commit
9. Push to git repo
Maybe this is issue to solve in the v3.0. Or maybe for another release plugin.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317639#comment-317639 ]
Mark Struberg commented on MRELEASE-777:
----------------------------------------
hi Fred!
If you use GIT, then please use the following config options
<localCheckout>true</..
<pushChanges>false</..
The first option will cause a git-clone from file:// locally, the 2nd one will prevent maven from pushing your local commits upstream.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Anatoly Kupriyanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319931#comment-319931 ]
Anatoly Kupriyanov commented on MRELEASE-777:
---------------------------------------------
Sorry, you are missing a part about the workingDirectory plugin configuration parameter where the plugin makes the clone. I don't talk about user's working copy.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317637#comment-317637 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
Guys, I see this is closed, however even if those options fix this guy's situation, doing a git clone is absolutely not an acceptable thing to do under any circumstances, is NOT analogous to an SVN checkout, and is for sure a "bug" or at least poor implementation. The *entire* repo is already local. The only sane things to do might be fetch or pull to ensure you're up to date, and do a checkout with GIT_DIR and GIT_WORK_TREE variables set appropriately. Can we reopen this until that's resolved? I had no idea that it was doing this during my releases, and am slightly disturbed to have read this. I only stumbled across it having a chat to the reporter in the freenode channel about some enhancements that he and I would both love to see, but that's another topic for some other issues :-)
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319911#comment-319911 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
Building twice seems to me to be necessary. The first pass is a "will it build OK" pass BEFORE committing the pom modifications. Without this you have to chance it, and roll back the commit if broken, which seems messy, even if done manually. I can see the chancing it thing being useful on a huge project, but I can't see any reason to have such a huge project in the first place, to be honest ;-) However it's certainly possible for it to be legit, whether yours is or not, and that should be enough to better support it. So my vote is for chancing it to be optional if at all possible.
I agree with your flow with one exception, clean -dxf, this is extremely dangerous and simply has to be an optional thing, if used at all. mvn clean should be sufficient, if not, your project seems to me to be broken. If you execute clean -dxf in some non-git sub-directory and have either your home dir or your root dir under git control with lots of stuff ignored, you're going to potentially nuke your entire account. Use with extreme caution. This IS a maven build, afterall.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319929#comment-319929 ]
Fred Cooke edited comment on MRELEASE-777 at 2/18/13 2:56 PM:
--------------------------------------------------------------
Your usecase is just one. I have ignored pngs/ and tmp/ which devs are allowed/encouraged to put their screenies, WIPs and other random files in. Running git clean -dfx destroys everything, which is a BIG surprise and VERY unwelcome as a default. It's a maven build, maven clean should be sufficient. If it is not, there are project structure problems to resolve (build output outside of target/).
was (Author: fredcooke):
Your usecase is just one. I have ignored pngs/ and tmp/ which devs are allowed/encouraged to put their screenies, WIPs and other random files in. Running git clean -dfx destroys everything, which is a BIG surprise and VERY unwelcome as a default. It's a maven build, maven clean should be sfufficient. If it is not, there are project structure problems to resolve (build output outside of target/).
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg closed MRELEASE-777.
----------------------------------
Resolution: Not A Bug
There are config options for this exact scenario
<localCheckout>true</localCheckout>
<pushChanges>false</pushChanges
Please add those 2 to the <configuration> section of the maven-release-plugin.
Here is the explanation why:
http://maven.apache.org/plugins/maven-release-plugin/prepare-mojo.html
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte reassigned MRELEASE-777:
---------------------------------------
Assignee: Mark Struberg
Actually, this is probably a SCM issue
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319897#comment-319897 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
My solution to this using variables wouldn't help you, however is likely correct from a historical point of view for most and would be a fraction faster than the hard-link clone. The trouble with your repo is that the hard links apply to the git objects, not the checked out tree, so merely creating a second copy is not acceptable for you, no matter how it's done. I've never understood why it's deemed necessary to create a second copy anyway. The system already checks to ensure that the original copy is clean before proceeding, why not just use it? +1 for an option to not do anything at all and just build in place.
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317647#comment-317647 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
That's not my repo, it's from the (fairly recent) link in the body of the issue. The original reporter is going to do some tests with the latest m-rel-p version. Can you explain how the GIT_DIR GIT_WORK_TREE git checkout method is not portable (across mac/win/lin at least)? I know it's fine on Linux and Mac, and likely any other *nix, but I don't know if non-cygwin Windows would be affected, or not.
In fact, if the code is calling for an 'scm *checkout*', as you say, then this seems the only honest thing to do, no matter how fast a local hard-link based clone is. How fast is that on NTFS, btw? Does git clone local use hardlinks on NTFS? It'd not be very nice to shaft Win users, even if it is a broken OS :-)
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Anatoly Kupriyanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319936#comment-319936 ]
Anatoly Kupriyanov edited comment on MRELEASE-777 at 2/18/13 3:22 PM:
----------------------------------------------------------------------
It is unclear because I am not sure. :)
It would be fine if the plugin at least doesn't delete the target/checkout, but pulls changes from the local repo ("localCheckout" parameter) and cleans it with "git clean". It will work fast enough, updating only changed files, not the whole repository.
However, in most cases it is even unnecessary, e.g. CI server could build in the basedir. So, it could be additional feature disabled by default, convenient for CIs.
BTW, why the release plugin doesn't run build "target/checkout" straight away?
was (Author: kan.izh):
It is unclear because I am not sure. :)
It would be fine if the plugin at least doesn't delete the target/checkout, but pulls changes from the local repo ("localCheckout" parameter). It will work fast enough, updating only changed files, not the whole repository.
However, in most cases it is even unnecessary, e.g. CI server could build in the basedir. So, it could be additional feature disabled by default, convenient for CIs.
BTW, why the release plugin doesn't run build "target/checkout" straight away?
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319932#comment-319932 ]
Fred Cooke commented on MRELEASE-777:
-------------------------------------
Wait, you're talking about target/checkout? A minute ago it seemed like you didn't want to use such a thing and wanted to just build in the basedir. I re-read your original post, and I can see what you meant, however it wasn't clear, and was made less clear with your list. What exactly do you want, in which directories, and when?
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-777) release plugin shouldn't git clone if the SCM
is git
Posted by "Anatoly Kupriyanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319936#comment-319936 ]
Anatoly Kupriyanov commented on MRELEASE-777:
---------------------------------------------
It is unclear because I am not sure. :)
It would be fine if the plugin at least doesn't delete the target/checkout, but pulls changes from the local repo ("localCheckout" parameter). It will work fast enough, updating only changed files, not the whole repository.
However, in most cases it is even unnecessary, e.g. CI server could build in the basedir. So, it could be additional feature disabled by default, convenient for CIs.
BTW, why the release plugin doesn't run build "target/checkout" straight away?
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
> Key: MRELEASE-777
> URL: https://jira.codehaus.org/browse/MRELEASE-777
> Project: Maven 2.x Release Plugin
> Issue Type: Improvement
> Environment: Linux x86_64, maven 2.2.1
> Reporter: Joel Orlina
> Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira