You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/10/08 08:59:23 UTC
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
jiridanek opened a new pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871
These options are enabled in PROTON-2170 and PROTON-2171.
Proton versions that don't implement this yet will ignore them and print a CMake warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705450048
Would there be a redundant use of "-DBUILD_TESTING=OFF" with the change? It already looks to be specified in the cmake command being run using the extra args variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705562654
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@7280cef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #871 +/- ##
=========================================
Coverage ? 86.54%
=========================================
Files ? 98
Lines ? 22414
Branches ? 0
=========================================
Hits ? 19399
Misses ? 3015
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=footer). Last update [7280cef...a3c3310](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705562654
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@7280cef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #871 +/- ##
=========================================
Coverage ? 86.54%
=========================================
Files ? 98
Lines ? 22414
Branches ? 0
=========================================
Hits ? 19399
Misses ? 3015
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=footer). Last update [7280cef...a3c3310](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705562654
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@7280cef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #871 +/- ##
=========================================
Coverage ? 86.54%
=========================================
Files ? 98
Lines ? 22414
Branches ? 0
=========================================
Hits ? 19399
Misses ? 3015
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=footer). Last update [7280cef...a3c3310](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705450048
Would there be a redundant use of "-DBUILD_TESTING=OFF" with the change? It already looks to be specified in the cmake command being run using the extra args variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705451429
I'll reformat the two long arg lines, so that I can easily see all that is passed in, for the next time. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705562654
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@7280cef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #871 +/- ##
=========================================
Coverage ? 86.54%
=========================================
Files ? 98
Lines ? 22414
Branches ? 0
=========================================
Hits ? 19399
Misses ? 3015
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=footer). Last update [7280cef...a3c3310](https://codecov.io/gh/apache/qpid-dispatch/pull/871?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #871: NO-JIRA: Skip building Proton examples and tests in GH Action
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #871:
URL: https://github.com/apache/qpid-dispatch/pull/871#issuecomment-705451429
I'll reformat the two long arg lines, so that I can easily see all that is passed in, for the next time. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org