You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/04/09 06:39:34 UTC
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9951
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
When events_ is empty in runtime-profile-counters.h:347, events_.back()
is undefined. This can lead to a crash. The fix is to check for
events_.empty() before calling back().
TODO: Find a way to test this
Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
---
M be/src/util/runtime-profile-counters.h
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/9951/1
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2260/
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 00:22:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 08:15:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 1:
You mentioned that status updates come in before any local events were logged, which caused this crash. That should be a case that we support right?
Why can't we add a backend test for this that does exactly that? Have a 'RuntimeProfile' with no events and then call update on it with a 'TRuntimeProfileNode' that has an 'EventSequence'.
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 16:47:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Tim Armstrong, Csaba Ringhofer,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9951
to look at the new patch set (#2).
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
When events_ is empty in runtime-profile-counters.h:347, events_.back()
is undefined. This can lead to a crash. The fix is to check for
events_.empty() before calling back().
This change adds a backend test to make sure that updating empty event
sequences doesn't crash.
Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
---
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile-test.cc
2 files changed, 34 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/9951/2
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
When events_ is empty in runtime-profile-counters.h:347, events_.back()
is undefined. This can lead to a crash. The fix is to check for
events_.empty() before calling back().
This change adds a backend test to make sure that updating empty event
sequences doesn't crash.
Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Reviewed-on: http://gerrit.cloudera.org:8080/9951
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile-test.cc
2 files changed, 34 insertions(+), 2 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 2:
(1 comment)
The build hit IMPALA-6092, will restart it.
http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:
http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h@348
PS1, Line 348: for (int64_t i = 0; i < timestamps.size(); ++i) {
> Let's not bother reserving, this code isn't perf critical so it doesn't rea
Done
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 00:27:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2266/
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 04:15:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 3: Code-Review+2
Carrying Tim's +2.
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 04:23:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 2:
Hit IMPALA-6338. This test was actually disabled today afternoon because it is a known flaky. I will rebase this change now and try again.
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 04:23:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:
http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h@348
PS1, Line 348: events_.reserve(events_.size() + timestamps.size());
> This will over reserve, if there are timestamps <= last_timestamp. As 'time
Let's not bother reserving, this code isn't perf critical so it doesn't really matter if there's an extra malloc() call or two - doesn't seem worth the complication.
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 16:06:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 20:16:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2260/
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 20:31:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:
http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h@348
PS1, Line 348: events_.reserve(events_.size() + timestamps.size());
This will over reserve, if there are timestamps <= last_timestamp. As 'timestamps' is sorted, a for loop could count till the first element to append, reserve the exact size, and the next for loop could simply push_back the rest.
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 14:49:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2268/
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 04:23:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2266/
--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 00:27:50 +0000
Gerrit-HasComments: No