You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2025/12/17 20:27:10 UTC
[PR] Separate API and impl [accumulo-access]
dlmarion opened a new pull request, #91:
URL: https://github.com/apache/accumulo-access/pull/91
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Separate API and impl [accumulo-access]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #91:
URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2628762120
##########
README.md:
##########
@@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java)
```
mvn clean package
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE
+
+JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java
Review Comment:
Would be nice to avoid having the version number in the readme because it will have to be updated. Also w/o the env var its shorter.
```suggestion
java --module-path=$(ls target/accumulo-access-*.jar) --add-modules=accumulo.access src/test/java/example/AccessExample.java
```
Looked into putting the example code into a module that requires the accumulo.access module and found this is not possible w/ this way of running it. These [docs](https://openjdk.org/jeps/330) mention the code is always run in the unamed module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Separate API and impl [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #91:
URL: https://github.com/apache/accumulo-access/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Separate API and impl [accumulo-access]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #91:
URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2631628475
##########
README.md:
##########
@@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java)
```
mvn clean package
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE
+
+JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java
Review Comment:
> do you have any issues with moving this to multi-module?
Seems like a good experiment to me. We had looked into making accumulo itself use modules and got stuck on the thrift code. All the server modules in accumulo need to use the thrift code in accumulo-core. Looking into modules again as part of reviewing this realized we may be able to get around that blocker by having an accumulo-core module explicitly allow access to its internals for only the server modules. Not sure if that would work, but I think this project provides a good place to try things out w/ modules. So I would be in favor of trying to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Separate API and impl [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #91:
URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2630991968
##########
README.md:
##########
@@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java)
```
mvn clean package
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE
+
+JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java
Review Comment:
> Looked into putting the example code into a module that requires the accumulo.access module and found this is not possible w/ this way of running it. These [docs](https://openjdk.org/jeps/330) mention the code is always run in the unamed module.
I feel like this should be possible. I'm thinking:
1. Put the example code in a module, let's call it `accumulo.access.examples`
2. In the examples module-info.java file, it would `requires accumulo.access`
3. Then, you would run the example by using the command:
```
java --module-path <dir> --module accumulo.access.examples/example.AccessExample
```
I can look at doing this after I merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Separate API and impl [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #91:
URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2631993611
##########
README.md:
##########
@@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java)
```
mvn clean package
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE
+
+JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java
Review Comment:
I put up #92. It breaks out the examples into multiple Maven modules and uses the Java module system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Separate API and impl [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #91:
URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2631108622
##########
README.md:
##########
@@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java)
```
mvn clean package
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE
+
+JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java
Review Comment:
I think this is going to require modifying accumulo-access to be a multi-module Maven project. I have no issue with this. We could likely move the antlr example to it's own module as well. @keith-turner @ctubbsii - do you have any issues with moving this to multi-module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Separate API and impl [accumulo-access]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #91:
URL: https://github.com/apache/accumulo-access/pull/91#discussion_r2631628475
##########
README.md:
##########
@@ -62,8 +62,10 @@ To run [AccessExample](src/test/java/example/AccessExample.java)
```
mvn clean package
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java
-CLASSPATH=$(ls target/accumulo-access-*.jar) java src/test/java/example/AccessExample.java RED BLUE
+
+JAVA_TOOL_OPTIONS="--module-path=target/accumulo-access-1.0.0-SNAPSHOT.jar --add-modules=accumulo.access" java src/test/java/example/AccessExample.java
Review Comment:
> do you have any issues with moving this to multi-module?
Seems like a good experiment to me. We had looked into making accumulo itself look into using modules and got stuck on the thrift code. All the server modules in accumulo need to use the thrift code in accumulo-core. Looking into modules again as part of reviewing this realized we may be able to get around that blocker by having an accumulo-core module explicitly allow access to its internals for only the server modules. Not sure if that would work, but I think this project provides a good place to try things out w/ modules. So I would be in favor of trying to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org