You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/10/07 17:24:06 UTC

Review Request 14518: SQOOP-1211 Sqoop2: Derby repo: Sync maximal length of versions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14518/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1211
    https://issues.apache.org/jira/browse/SQOOP-1211


Repository: sqoop-sqoop2


Description
-------

Increased size of the field SQ_CONNECTOR.SQC_VERSION to 64 and provided upgrade path.


Diffs
-----

  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 200293d842f5e040e0fa603371b597d414f225ad 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 851e36cb50d894b9570e69021e4824bb4c39fff5 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 8016ad896855ffb1d7c7fc08d09c56d6713d3875 

Diff: https://reviews.apache.org/r/14518/diff/


Testing
-------

Unit and integration tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request 14518: SQOOP-1211 Sqoop2: Derby repo: Sync maximal length of versions

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14518/#review26744
-----------------------------------------------------------

Ship it!


LGTM

- Venkat Ranganathan


On Oct. 7, 2013, 3:24 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14518/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2013, 3:24 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1211
>     https://issues.apache.org/jira/browse/SQOOP-1211
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Increased size of the field SQ_CONNECTOR.SQC_VERSION to 64 and provided upgrade path.
> 
> 
> Diffs
> -----
> 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 200293d842f5e040e0fa603371b597d414f225ad 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 851e36cb50d894b9570e69021e4824bb4c39fff5 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 8016ad896855ffb1d7c7fc08d09c56d6713d3875 
> 
> Diff: https://reviews.apache.org/r/14518/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>