You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/01 21:38:18 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

gengliangwang commented on a change in pull request #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r280226020
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
 ##########
 @@ -274,6 +277,7 @@ class FileStreamSinkSuite extends StreamTest {
             "CAST(start as BIGINT) AS start",
             "CAST(end as BIGINT) AS end",
             "count")
+          .orderBy("start") // sort the DataFrame in order to compare with the expected one.
 
 Review comment:
   Talked with @jose-torres offline. The ordering of result here is not guaranteed. Add `orderBy` to fix the test case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org