You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/24 23:51:36 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35964: [SPARK-38646] Pull a trait out for Python functions
HyukjinKwon commented on a change in pull request #35964:
URL: https://github.com/apache/spark/pull/35964#discussion_r834841875
##########
File path: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
##########
@@ -73,14 +73,27 @@ private[spark] class PythonRDD(
* A wrapper for a Python function, contains all necessary context to run the function in Python
* runner.
*/
-private[spark] case class PythonFunction(
+trait PythonFunction {
Review comment:
```suggestion
private[spark] trait PythonFunction {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org