You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/13 22:52:39 UTC

[GitHub] [tvm] nodeav opened a new pull request #8039: Fix minor issues in the tvmc tune CLI

nodeav opened a new pull request #8039:
URL: https://github.com/apache/tvm/pull/8039


   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] nodeav commented on a change in pull request #8039: Fix minor issues in the tvmc tune CLI

Posted by GitBox <gi...@apache.org>.
nodeav commented on a change in pull request #8039:
URL: https://github.com/apache/tvm/pull/8039#discussion_r632381220



##########
File path: python/tvm/driver/tvmc/autotuner.py
##########
@@ -116,7 +116,7 @@ def add_tune_parser(subparsers):
         help="the host compilation target, defaults to 'llvm'",
         default="llvm",
     )
-    parser.add_argument("--timeout", default=10, help="compilation timeout, in seconds")
+    parser.add_argument("--timeout", default=10, help="compilation timeout, in seconds", type=int)

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #8039: Fix minor issues in the tvmc tune CLI

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #8039:
URL: https://github.com/apache/tvm/pull/8039#issuecomment-841378395


   Thanks @nodeav @leandron @jwfromm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac merged pull request #8039: Fix minor issues in the tvmc tune CLI

Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #8039:
URL: https://github.com/apache/tvm/pull/8039


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #8039: Fix minor issues in the tvmc tune CLI

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8039:
URL: https://github.com/apache/tvm/pull/8039#discussion_r632151817



##########
File path: python/tvm/driver/tvmc/autotuner.py
##########
@@ -116,7 +116,7 @@ def add_tune_parser(subparsers):
         help="the host compilation target, defaults to 'llvm'",
         default="llvm",
     )
-    parser.add_argument("--timeout", default=10, help="compilation timeout, in seconds")
+    parser.add_argument("--timeout", default=10, help="compilation timeout, in seconds", type=int)

Review comment:
       ```suggestion
       parser.add_argument("--timeout", type=int, default=10, help="compilation timeout, in seconds")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org