You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/12 10:08:54 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic

Pearl1594 opened a new pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020


   ### Description
   
   For Basic Zones, additional IP ranges can be added for the guest traffic, however, in the new UI, it isn't possible to add IP ranges.
   Legacy UI:
   ![image](https://user-images.githubusercontent.com/10495417/117957001-3a712980-b337-11eb-9a7a-7f91254e7dd6.png)
   
   Current UI:
   Doesn't have the provision for adding additional IP range.
   ![image](https://user-images.githubusercontent.com/10495417/117957223-7906e400-b337-11eb-8c68-dc2533f7c2b6.png)
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [X] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   ![image](https://user-images.githubusercontent.com/10495417/117957769-02b6b180-b338-11eb-9023-e972fa7ccf23.png)
   
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839649994


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839716838


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5020 (SL-JID-136)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839716546


   @Pearl1594 it is there in 4.15 branch I think
   ![Screenshot from 2021-05-12 17-34-02](https://user-images.githubusercontent.com/153340/117972123-5af5af80-b348-11eb-9440-d7e728404245.png)
   
   Though I'm fine we want to provide it in Infra section as well.
   cc @rhtyd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839714147


   @rhtyd I don't see that option 
   ![image](https://user-images.githubusercontent.com/10495417/117971622-c4c18980-b347-11eb-9d53-7a897f460770.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839649568


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#discussion_r630943472



##########
File path: ui/src/views/infra/network/TrafficTypesTab.vue
##########
@@ -129,6 +140,35 @@ export default {
       }).finally(() => {
         this.fetchLoading = false
       })
+
+      this.fetchLoading = true
+      api('listZones', { id: this.resource.zoneid }).then(json => {
+        const zone = json.listzonesresponse.zone || []
+        this.networkType = zone[0].networktype
+      }).catch(error => {
+        this.$notifyError(error)
+      }).finally(() => {
+        this.fetchLoading = false
+      })
+    },
+    fetchGuestNetwork () {
+      if (this.networkType === 'Basic') {

Review comment:
       @Pearl1594 Can you please check if this even called. Default value for `networkType` is `Advanced` and `fetchGuestNetwork` is called before finding `networkType` at line 147. I think `network` object of IpRangesTabPublic.vue will always remain empty.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839710673


   Is it available if you go to the network -> ip ranges? I think I saw some change by someone recently for shared networks (adding IP range).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839712578


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic in Basic Zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839712930


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5020: ui: Allow IP range creation for Physical Network - Guest Traffic

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5020:
URL: https://github.com/apache/cloudstack/pull/5020#issuecomment-839653037


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5020 (SL-JID-135)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org