[GitHub] [superset] villebro commented on a change in pull request #19327: fix(dashboard): Chart stuck in loading state when when datasets request and chart request fail

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #19327:
URL: https://github.com/apache/superset/pull/19327#discussion_r833223400



##########
File path: superset-frontend/src/components/Chart/Chart.jsx
##########
@@ -216,7 +219,8 @@ class Chart extends React.PureComponent {
     if (
       chartAlert !== undefined &&
       chartAlert !== NONEXISTENT_DATASET &&
-      datasource === PLACEHOLDER_DATASOURCE
+      datasource === PLACEHOLDER_DATASOURCE &&
+      datasetsStatus !== ResourceStatus.ERROR

Review comment:
       I haven't worked on this component for a while, but I would have expected it to check the other way around, i.e. are the conditions met for displaying the error, and if not, only *then* display the spinner. But I don't propose changing this now as it would probably introduce unnecessary regression risk.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org