You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/04 08:54:44 UTC
[GitHub] [camel-quarkus] gnodet opened a new issue #844: Duplicate
LICENSE(.txt) and NOTICE(.txt) files in the source distribution
gnodet opened a new issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate
LICENSE(.txt) and NOTICE(.txt) files in the source distribution
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594494670
@gnodet could you please sketch how did you find this issue? I have an idea where the problem is but I'd like to make sure that my fix will meet your acceptance criteria.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate
LICENSE(.txt) and NOTICE(.txt) files in the source distribution
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-597040206
I was able to reproduce using `mvn -Papache-release release:prepare -DpushChanges=false`.
I'd say the extension-less `NOTICE` and `LICENSE` files are unwanted. They come via `org.apache.apache.resources:apache-source-release-assembly-descriptor` artifact that is added as a dependency of the assembly plugin in the apache parent: https://github.com/apache/maven-apache-parent/blob/apache-21/pom.xml#L352-L378
It does not happen with Camel because Camel seems to provide its own assembly descriptor in https://github.com/apache/camel/blob/master/apache-camel/pom.xml#L227 . We should perhaps do the same. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga closed issue #844: Duplicate LICENSE(.txt)
and NOTICE(.txt) files in the source distribution
Posted by GitBox <gi...@apache.org>.
ppalaga closed issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on issue #844: Duplicate
LICENSE(.txt) and NOTICE(.txt) files in the source distribution
Posted by GitBox <gi...@apache.org>.
gnodet commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594535614
I don't know, i just unzipped the source distribution that was being voted.
I don't see any maven assembly plugin though, it may be inherited from the apache parent pom. @oscerd any idea as you did the release ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate
LICENSE(.txt) and NOTICE(.txt) files in the source distribution
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594495544
I mean, how do I build the source distro?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #844: Duplicate
LICENSE(.txt) and NOTICE(.txt) files in the source distribution
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594536066
It should come from the apache parent pom and pass through the release profile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate
LICENSE(.txt) and NOTICE(.txt) files in the source distribution
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594546304
OK, let me try `mvn -Prelease release:prepare -DpushChanges=false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services