You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:09:38 UTC

[GitHub] [mynewt-newtmgr] ccollins476ad commented on pull request #162: Optimize DFU

ccollins476ad commented on pull request #162:
URL: https://github.com/apache/mynewt-newtmgr/pull/162#issuecomment-640961098


   Sorry for the delay.  It looks good to me (not sure why I thought you would need to look at sequence numbers).
   
   I just have one last request: could you please make `IMAGE_UPLOAD_MAX_WS` configurable via a command line option?  The only reason I ask is that I worry that this optimized DFU method might cause problems on some setups that we aren't anticipating (e.g., lower mbuf count).  In such cases, it would be good if the user could set the max window size to 1.  I'll be much more prompt next time!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org