[GitHub] [accumulo] keith-turner commented on issue #3254: Comparisons between TserverInstance and TabletMetadata.Location are error prone

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on issue #3254:
URL: https://github.com/apache/accumulo/issues/3254#issuecomment-1482775944

   > Should this be targeted for 2.1.1 or 3.0?
   
   Its not public API so we can change it in 2.1.1 if we want.  In its current state it is tricky code and anyone writing new code against it would have to be really careful to understand its nuances (like calling equals on two location objects will not behave in an expected way).   In my opinion its worth attempting to fix in 2.1, but I don't know how extensive the fix will end up being. Personally I would start in 2.1 and if it started to feel like the fix might cause new bugs then I might only fix it in 3.
   
   Yesterday I took a quick look at how many things called TabletMetadata.getLocation and it was around 50, but didn't further investigate how many of those might be doing equal, set, or map operations with the objects.  I don't have a good feel for how much code the fix will end up touching.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org