[jira] [Comment Edited] (HBASE-23811) [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty

["Michael Stack (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032712#comment-17032712 ] 

Michael Stack edited comment on HBASE-23811 at 2/7/20 10:35 PM:
----------------------------------------------------------------

We should probably upgrade our libthrift.

What other dependencies does it bring in [~weichiu]?

Thirdparty generally is those popular libs we'd like to be up-to-date on; protobuf, guava, etc. We shade them so we can update w/o having to worry about the version upstream sports.

Let me know if you want to run an hbase-thirdparty release... Can do that for you sir.




was (Author: stack):
We should probably upgrade our libthrift.

What other dependencies does it bring in [~weichiu]?

Let me know if you want to run an hbase-thirdparty release... Can do that for you sir.



> [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty
> -----------------------------------------------------------------
>
>                 Key: HBASE-23811
>                 URL: https://issues.apache.org/jira/browse/HBASE-23811
>             Project: HBase
>          Issue Type: Sub-task
>          Components: thirdparty
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Major
>
> JaegerTracing pulls in lots of dependencies. Some, like libthrift (0.13.0) conflicts the one ships in HBase (0.12.0).
> Additionally, not everyone may want to use Jaeger.
> I propose to shade JaegerTracing and its dependencies into an uber jar, place it as a hbase-thirdparty artifact. As an added benefit, this makes the management of tracers in the HBase's dependency tree much easier. Finally, we can follow the same suit and provide Zipkin tracer support in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)