You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/01 23:00:53 UTC

[GitHub] [beam] ibzib commented on a change in pull request #11593: [BEAM-9870] Always generate Dataflow-compatible FnApi protos.

ibzib commented on a change in pull request #11593:
URL: https://github.com/apache/beam/pull/11593#discussion_r418771952



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -345,7 +345,7 @@ def visit_transform(self, transform_node):
           for ix, side_input in enumerate(transform_node.side_inputs):
             access_pattern = side_input._side_input_data().access_pattern
             if access_pattern == common_urns.side_inputs.ITERABLE.urn:
-              if use_unified_worker:
+              if use_unified_worker or not use_fn_api:

Review comment:
       I'm a bit confused about the purpose of this change, if `new_side_input` is only used when `use_fn_api` is True?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org