You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2025/12/12 08:44:59 UTC
[PR] WIP [SPARK-54571] Use safeDecompressor [spark]
pan3793 opened a new pull request, #53454:
URL: https://github.com/apache/spark/pull/53454
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] WIP [SPARK-54571] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53454:
URL: https://github.com/apache/spark/pull/53454#issuecomment-3652658015
cc @dbtsai @huaxingao, `com.ibm.db2:jcc` includes unshaded old lz4 classes, which causes sql/hive/docker-it modules test failure after this patch
```
java.lang.NoSuchMethodError: 'net.jpountz.lz4.LZ4BlockInputStream$Builder net.jpountz.lz4.LZ4BlockInputStream.newBuilder()'
at org.apache.spark.io.LZ4CompressionCodec.compressedInputStream(CompressionCodec.scala:156)
...
```
I checked all versions available in Maven Central, all of them have the same issue.
https://mvnrepository.com/artifact/com.ibm.db2/jcc
I don't find the public contact info of the IBM DB2 JDBC driver team, not sure what's the next step, temporarily purge the dependency and disable DB2 tests? Or any better ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #53454:
URL: https://github.com/apache/spark/pull/53454#issuecomment-3882841594
Hmm, so that's said, in lz4-java 1.10.1, fastDecompressor is paradoxically much slower than safeDecompressor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "dbtsai (via GitHub)" <gi...@apache.org>.
dbtsai commented on PR #53454:
URL: https://github.com/apache/spark/pull/53454#issuecomment-3882492055
@viirya can you take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53454:
URL: https://github.com/apache/spark/pull/53454#issuecomment-3784160781
cc @dbtsai @mridulm @dongjoon-hyun @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2716751363
##########
pom.xml:
##########
@@ -340,7 +340,8 @@
<mariadb.java.client.version>2.7.12</mariadb.java.client.version>
<mysql.connector.version>9.2.0</mysql.connector.version>
<postgresql.version>42.7.7</postgresql.version>
- <db2.jcc.version>11.5.9.0</db2.jcc.version>
+ <!-- A special version that bundles lz4-java 1.10.1 -->
+ <db2.jcc.version>12.1.3.0_special_74723</db2.jcc.version>
Review Comment:
okay, let me upgrade it first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2715740458
##########
pom.xml:
##########
@@ -340,7 +340,8 @@
<mariadb.java.client.version>2.7.12</mariadb.java.client.version>
<mysql.connector.version>9.2.0</mysql.connector.version>
<postgresql.version>42.7.7</postgresql.version>
- <db2.jcc.version>11.5.9.0</db2.jcc.version>
+ <!-- A special version that bundles lz4-java 1.10.1 -->
+ <db2.jcc.version>12.1.3.0_special_74723</db2.jcc.version>
Review Comment:
this dep is only used for testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2716880582
##########
pom.xml:
##########
@@ -340,7 +340,8 @@
<mariadb.java.client.version>2.7.12</mariadb.java.client.version>
<mysql.connector.version>9.2.0</mysql.connector.version>
<postgresql.version>42.7.7</postgresql.version>
- <db2.jcc.version>11.5.9.0</db2.jcc.version>
+ <!-- A special version that bundles lz4-java 1.10.1 -->
+ <db2.jcc.version>12.1.3.0_special_74723</db2.jcc.version>
Review Comment:
@LuciferYang FYI, I opened SPARK-55136 (https://github.com/apache/spark/pull/53920) for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2792009418
##########
core/src/main/scala/org/apache/spark/io/CompressionCodec.scala:
##########
@@ -153,11 +153,11 @@ class LZ4CompressionCodec(conf: SparkConf) extends CompressionCodec {
override def compressedInputStream(s: InputStream): InputStream = {
val disableConcatenationOfByteStream = false
- new LZ4BlockInputStream(
- s,
- lz4Factory.fastDecompressor(),
- xxHashFactory.newStreamingHash32(defaultSeed).asChecksum,
- disableConcatenationOfByteStream)
+ LZ4BlockInputStream.newBuilder()
+ .withDecompressor(lz4Factory.safeDecompressor())
+ .withChecksum(xxHashFactory.newStreamingHash32(defaultSeed).asChecksum)
+ .withStopOnEmptyBlock(disableConcatenationOfByteStream)
Review Comment:
yes, exactly, you can check the source code at
https://github.com/yawkat/lz4-java/blob/33d180cb70c4d93c80fb0dc3ab3002f457e93840/src/java/net/jpountz/lz4/LZ4BlockInputStream.java#L69
```
public LZ4BlockInputStream(InputStream in, LZ4FastDecompressor fastDecompressor, Checksum checksum, boolean stopOnEmptyBlock) {
this(in, fastDecompressor, null, checksum, stopOnEmptyBlock);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2791980872
##########
core/src/main/scala/org/apache/spark/io/CompressionCodec.scala:
##########
@@ -153,11 +153,11 @@ class LZ4CompressionCodec(conf: SparkConf) extends CompressionCodec {
override def compressedInputStream(s: InputStream): InputStream = {
val disableConcatenationOfByteStream = false
- new LZ4BlockInputStream(
- s,
- lz4Factory.fastDecompressor(),
- xxHashFactory.newStreamingHash32(defaultSeed).asChecksum,
- disableConcatenationOfByteStream)
+ LZ4BlockInputStream.newBuilder()
+ .withDecompressor(lz4Factory.safeDecompressor())
+ .withChecksum(xxHashFactory.newStreamingHash32(defaultSeed).asChecksum)
+ .withStopOnEmptyBlock(disableConcatenationOfByteStream)
Review Comment:
Is this `.withStopOnEmptyBlock(disableConcatenationOfByteStream)` a correct mapping to previous behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-54571] Use LZ4 safeDecompressor [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53454:
URL: https://github.com/apache/spark/pull/53454#issuecomment-3782728730
## JIRA Issue Information
=== Improvement SPARK-54571 ===
Summary: Use LZ4 safeDecompressor
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] WIP [SPARK-54571] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53454:
URL: https://github.com/apache/spark/pull/53454#issuecomment-3651875442
the test failure is caused by `com.ibm.db2:jcc` includes unshaded old lz4 classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2716739710
##########
pom.xml:
##########
@@ -340,7 +340,8 @@
<mariadb.java.client.version>2.7.12</mariadb.java.client.version>
<mysql.connector.version>9.2.0</mysql.connector.version>
<postgresql.version>42.7.7</postgresql.version>
- <db2.jcc.version>11.5.9.0</db2.jcc.version>
+ <!-- A special version that bundles lz4-java 1.10.1 -->
+ <db2.jcc.version>12.1.3.0_special_74723</db2.jcc.version>
Review Comment:
Can we upgrade it first in a separate pr？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53454:
URL: https://github.com/apache/spark/pull/53454#issuecomment-3882860725
@viirya yeah, it was mentioned in https://sites.google.com/sonatype.com/vulnerabilities/cve-2025-12183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2791986080
##########
pom.xml:
##########
@@ -340,7 +340,8 @@
<mariadb.java.client.version>2.7.12</mariadb.java.client.version>
<mysql.connector.version>9.2.0</mysql.connector.version>
<postgresql.version>42.7.7</postgresql.version>
- <db2.jcc.version>11.5.9.0</db2.jcc.version>
+ <!-- A special version that bundles lz4-java 1.10.1 -->
+ <db2.jcc.version>12.1.3.0_special_74723</db2.jcc.version>
Review Comment:
Does it mean we need to update this dependency when upgrading lz4-java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54571][CORE][SQL] Use LZ4 safeDecompressor [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #53454:
URL: https://github.com/apache/spark/pull/53454#discussion_r2792015797
##########
pom.xml:
##########
@@ -340,7 +340,8 @@
<mariadb.java.client.version>2.7.12</mariadb.java.client.version>
<mysql.connector.version>9.2.0</mysql.connector.version>
<postgresql.version>42.7.7</postgresql.version>
- <db2.jcc.version>11.5.9.0</db2.jcc.version>
+ <!-- A special version that bundles lz4-java 1.10.1 -->
+ <db2.jcc.version>12.1.3.0_special_74723</db2.jcc.version>
Review Comment:
@viirya, ideally, we should, but I'm afraid we can't, we can discuss the Db2 JDBC issue in the dedicated PR https://github.com/apache/spark/pull/53920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org