You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/17 14:56:07 UTC

[GitHub] [shardingsphere] roodkcab opened a new pull request #14148: fix 14144

roodkcab opened a new pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148


   Fixes #14144.
   
   Changes proposed in this pull request:
   - get last_insert_id on update set it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on pull request #14148: fix 14144

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148#issuecomment-1012744916


   Hello, any update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #14148: fix 14144

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148#issuecomment-997674023


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14148?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14148](https://codecov.io/gh/apache/shardingsphere/pull/14148?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95c79e8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a2a7bc5233106fac49487fa8345b8f801061a00c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2a7bc5) will **decrease** coverage by `2.64%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/14148/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/14148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #14148      +/-   ##
   ============================================
   - Coverage     63.64%   60.99%   -2.65%     
   + Complexity     1843     1766      -77     
   ============================================
     Files          2865     2853      -12     
     Lines         42737    42441     -296     
     Branches       7269     7243      -26     
   ============================================
   - Hits          27198    25889    -1309     
   - Misses        13453    14548    +1095     
   + Partials       2086     2004      -82     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/14148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../proxy/backend/communication/ProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL1Byb3h5U1FMRXhlY3V0b3IuamF2YQ==) | `30.18% <0.00%> (-4.60%)` | :arrow_down: |
   | [...data/pipeline/core/datasource/MetaDataManager.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvZGF0YXNvdXJjZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...st/channel/distribution/AbstractBitSetChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2NoYW5uZWwvZGlzdHJpYnV0aW9uL0Fic3RyYWN0Qml0U2V0Q2hhbm5lbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/channel/distribution/AutoAcknowledgeChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2NoYW5uZWwvZGlzdHJpYnV0aW9uL0F1dG9BY2tub3dsZWRnZUNoYW5uZWwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...core/ingest/channel/distribution/ManualBitSet.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2NoYW5uZWwvZGlzdHJpYnV0aW9uL01hbnVhbEJpdFNldC5qYXZh) | `0.00% <0.00%> (-97.78%)` | :arrow_down: |
   | [...gest/channel/distribution/DistributionChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2NoYW5uZWwvZGlzdHJpYnV0aW9uL0Rpc3RyaWJ1dGlvbkNoYW5uZWwuamF2YQ==) | `0.00% <0.00%> (-87.33%)` | :arrow_down: |
   | [...ta/pipeline/core/ingest/channel/MemoryChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2NoYW5uZWwvTWVtb3J5Q2hhbm5lbC5qYXZh) | `0.00% <0.00%> (-86.37%)` | :arrow_down: |
   | [...est/channel/distribution/BlockingQueueChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2NoYW5uZWwvZGlzdHJpYnV0aW9uL0Jsb2NraW5nUXVldWVDaGFubmVsLmphdmE=) | `0.00% <0.00%> (-85.00%)` | :arrow_down: |
   | [...dingsphere/data/pipeline/core/util/ThreadUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvdXRpbC9UaHJlYWRVdGlsLmphdmE=) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [...ta/pipeline/core/datasource/DataSourceWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvZGF0YXNvdXJjZS9EYXRhU291cmNlV3JhcHBlci5qYXZh) | `0.00% <0.00%> (-60.87%)` | :arrow_down: |
   | ... and [176 more](https://codecov.io/gh/apache/shardingsphere/pull/14148/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14148?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14148?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a2a7bc5...95c79e8](https://codecov.io/gh/apache/shardingsphere/pull/14148?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN commented on pull request #14148: fix 14144

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148#issuecomment-1024855861


   Close due to no response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] menghaoranss commented on pull request #14148: fix 14144

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148#issuecomment-997547644


   @roodkcab ci build failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] roodkcab commented on pull request #14148: fix 14144

Posted by GitBox <gi...@apache.org>.
roodkcab commented on pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148#issuecomment-997651279


   @menghaoranss hi, is there anyway to trigger ci run again without push?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN closed pull request #14148: fix 14144

Posted by GitBox <gi...@apache.org>.
TeslaCN closed pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #14148: fix 14144

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #14148:
URL: https://github.com/apache/shardingsphere/pull/14148#discussion_r773709851



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/ProxySQLExecutor.java
##########
@@ -112,7 +115,16 @@ private boolean isExecuteDDLInPostgreSQLOpenGaussTransaction(final SQLStatement
         String schemaName = backendConnection.getConnectionSession().getSchemaName();
         Collection<ShardingSphereRule> rules = ProxyContext.getInstance().getContextManager().getMetaDataContexts().getMetaData(schemaName).getRuleMetaData().getRules();
         int maxConnectionsSizePerQuery = ProxyContext.getInstance().getContextManager().getMetaDataContexts().getProps().<Integer>getValue(ConfigurationPropertyKey.MAX_CONNECTIONS_SIZE_PER_QUERY);
-        boolean isReturnGeneratedKeys = executionContext.getSqlStatementContext().getSqlStatement() instanceof MySQLInsertStatement;
+        final SQLStatement stmt = executionContext.getSqlStatementContext().getSqlStatement();
+        boolean isReturnGeneratedKeys = stmt instanceof MySQLInsertStatement;
+        if (stmt instanceof MySQLUpdateStatement) {
+            for (final AssignmentSegment segment : ((MySQLUpdateStatement) stmt).getSetAssignment().getAssignments()) {

Review comment:
       The value of `isReturnGeneratedKeys` controls whether we get generated key from ResultSet. Maybe looking for function `last_insert_id` in statement is not right.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org