You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jayush Luniya <jl...@hortonworks.com> on 2016/03/30 07:11:55 UTC

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/
-----------------------------------------------------------

(Updated March 30, 2016, 5:11 a.m.)


Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.


Bugs: AMBARI-15578
    https://issues.apache.org/jira/browse/AMBARI-15578


Repository: ambari


Description
-------

Stack Featurize Atlas Service


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py da34696 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py 8fabaac 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py b6374f9 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 097765e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 86e5971 

Diff: https://reviews.apache.org/r/45470/diff/


Testing
-------

mvn clean test -DskipSurefireTests
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.063s
[INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
[INFO] Final Memory: 63M/1108M
[INFO] ------------------------------------------------------------------------


Thanks,

Jayush Luniya


Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/#review126427
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On March 30, 2016, 5:15 a.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45470/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15578
>     https://issues.apache.org/jira/browse/AMBARI-15578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack Featurize Atlas Service
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py da34696 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py 8fabaac 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py b6374f9 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 097765e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 86e5971 
> 
> Diff: https://reviews.apache.org/r/45470/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -DskipSurefireTests
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54.063s
> [INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
> [INFO] Final Memory: 63M/1108M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>


Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On March 30, 2016, 6:02 p.m., Juanjo  Marron wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json, line 107
> > <https://reviews.apache.org/r/45470/diff/2/?file=1318744#file1318744line107>
> >
> >     Is it rolling_upgrade related or the version where Atlas was introduced in the stack?
> >     
> >     {
> >           "name": "atlas",
> >           "description": "Atlas Service support",
> >           "min_version": "2.3.0.0"
> >         }
> >     
> >     I think rolling upgrade and config versioning could be added as features later on when supported

Its actually RU related. Atlas has partial support for RU in 2.3.0.0. The upgrade logic will need to be revisited for Atlas.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/#review126157
-----------------------------------------------------------


On March 30, 2016, 5:15 a.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45470/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15578
>     https://issues.apache.org/jira/browse/AMBARI-15578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack Featurize Atlas Service
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py da34696 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py 8fabaac 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py b6374f9 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 097765e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 86e5971 
> 
> Diff: https://reviews.apache.org/r/45470/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -DskipSurefireTests
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54.063s
> [INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
> [INFO] Final Memory: 63M/1108M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>


Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/#review126157
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json (line 107)
<https://reviews.apache.org/r/45470/#comment189057>

    Is it rolling_upgrade related or the version where Atlas was introduced in the stack?
    
    {
          "name": "atlas",
          "description": "Atlas Service support",
          "min_version": "2.3.0.0"
        }
    
    I think rolling upgrade and config versioning could be added as features later on when supported


- Juanjo  Marron


On March 30, 2016, 5:15 a.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45470/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15578
>     https://issues.apache.org/jira/browse/AMBARI-15578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack Featurize Atlas Service
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py da34696 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py 8fabaac 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py b6374f9 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 097765e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 86e5971 
> 
> Diff: https://reviews.apache.org/r/45470/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -DskipSurefireTests
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54.063s
> [INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
> [INFO] Final Memory: 63M/1108M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>


Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/#review126192
-----------------------------------------------------------


Ship it!




Ship It!

- Juanjo  Marron


On March 30, 2016, 5:15 a.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45470/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15578
>     https://issues.apache.org/jira/browse/AMBARI-15578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack Featurize Atlas Service
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py da34696 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py 8fabaac 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py b6374f9 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 097765e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 86e5971 
> 
> Diff: https://reviews.apache.org/r/45470/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -DskipSurefireTests
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54.063s
> [INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
> [INFO] Final Memory: 63M/1108M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>


Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/
-----------------------------------------------------------

(Updated March 30, 2016, 5:15 a.m.)


Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.


Bugs: AMBARI-15578
    https://issues.apache.org/jira/browse/AMBARI-15578


Repository: ambari


Description
-------

Stack Featurize Atlas Service


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py da34696 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py 8fabaac 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py b6374f9 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 097765e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 86e5971 

Diff: https://reviews.apache.org/r/45470/diff/


Testing
-------

mvn clean test -DskipSurefireTests
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.063s
[INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
[INFO] Final Memory: 63M/1108M
[INFO] ------------------------------------------------------------------------


Thanks,

Jayush Luniya