You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/28 10:15:52 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #13224: Support google-cloud-datacatalog 3.0.0

mik-laj commented on a change in pull request #13224:
URL: https://github.com/apache/airflow/pull/13224#discussion_r549292567



##########
File path: airflow/providers/google/cloud/hooks/datacatalog.py
##########
@@ -18,16 +18,18 @@
 from typing import Dict, Optional, Sequence, Tuple, Union
 
 from google.api_core.retry import Retry
-from google.cloud.datacatalog_v1beta1 import DataCatalogClient
-from google.cloud.datacatalog_v1beta1.types import (
+from google.cloud import datacatalog
+from google.cloud.datacatalog_v1beta1 import (
+    CreateTagRequest,
+    DataCatalogClient,
     Entry,
     EntryGroup,
-    FieldMask,
     SearchCatalogRequest,
     Tag,
     TagTemplate,
     TagTemplateField,
 )
+from google.protobuf import field_mask_pb2 as field_mask  # type: ignore

Review comment:
       It just copied these lines from the Google library, but it will delete the alias, because it is not needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org