Re: [PR] HDDS-14003. EventNotification: Added protobufs and entity class [ozone]

["errose28 (via GitHub)" <gi...@apache.org>]

errose28 commented on code in PR #9363:
URL: https://github.com/apache/ozone/pull/9363#discussion_r2765819349


##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -917,6 +917,68 @@ message SnapshotDiffJobProto {
   optional double keysProcessedPct = 13;
 }
 
+/**
+ * Per request type entities to hold arguments
+ * captured for CompletedRequestInfo
+ */
+message CreateVolumeOperationArgs {
+}
+
+message DeleteVolumeOperationArgs {
+}
+
+message CreateBucketOperationArgs {
+}
+
+message DeleteBucketOperationArgs {
+}
+
+message CreateKeyOperationArgs {
+}
+
+message RenameKeyOperationArgs {
+    required string toKeyName = 1;
+}
+
+message DeleteKeyOperationArgs {
+}
+
+message CommitKeyOperationArgs {
+}
+
+message CreateDirectoryOperationArgs {
+}
+
+message CreateFileOperationArgs {
+    required bool isRecursive = 2;
+    required bool isOverwrite = 3;
+}
+
+
+/**
+ * CompletedRequestInfo table entry
+ */
+message CompletedRequestInfo {
+
+  optional int64 trxLogIndex = 1;

Review Comment:
   @ChenSammi what are you suggesting as the immediate change in this PR? For Ozone in general I do not think we should be adding required proto fields to any new messages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org