[GitHub] jedrivisser opened a new pull request #486: GH-485: (android) Replace deprecated "compile" with "implementation"

[GitBox <gi...@apache.org>]

jedrivisser opened a new pull request #486: GH-485: (android) Replace deprecated "compile" with "implementation"
URL: https://github.com/apache/cordova-android/pull/486
 
 
   ### Platforms affected
   android
   
   ### What does this PR do?
   generates gradle dependencies in the `build.gradle` from `<framework>` elements found in the `plugin.xml` as the new `implementation` dependencies instead of deprecated `compile` dependencies
   
   ### What testing has been done on this change?
   ran `npm run test`
   
   ### Checklist
   - [✘] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   Created a github Issue: https://github.com/apache/cordova-android/issues/485
   
   - [✓] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   
   - [✓ ] Added automated test coverage as appropriate for this change.
   None were needed
   
   There are some more references to `compile` dependencies in other files but I left them alone bacause I am not sure what they are used for, see:
   
   https://github.com/apache/cordova-android/blob/7.1.x/bin/templates/cordova/lib/plugin-build.gradle#L41-L43
   https://github.com/apache/cordova-android/blob/7.1.x/spec/fixtures/android_studio_project/app/build.gradle#L23-L25
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org