You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/09/19 18:12:54 UTC

Re: [PR] GH-43680: [Integration] Unskip nanoarrow in IPC integration tests [arrow]

paleolimbot commented on PR #43715:
URL: https://github.com/apache/arrow/pull/43715#issuecomment-2361864134

   Just a few notes from some investigating:
   
   - I reran the workflow since we've fixed the Go nullability issue and at least one issue with big endian footers since the last run
   - The Python errors for nanoarrow produce/consume are in archery and can be fixed with
   
   ```diff
   --- a/dev/archery/archery/integration/tester_nanoarrow.py
   +++ b/dev/archery/archery/integration/tester_nanoarrow.py
   @@ -56,8 +56,8 @@ class NanoarrowTester(Tester):
                'JSON_PATH': json_path,
                'COMMAND': command,
                **{
   -                f'QUIRK_{q}': 1
   -                for q in quirks or []
   +                f'QUIRK_{q}': "1"
   +                for q in quirks or ""
                },
   ```
   
   - After that, nanoarrow produce/consume with itself passes golden file tests for 1.0.0-littleendian, but not any of the others.
   - nanoarrow's reader seems to choke on certain types of offset buffers exported by JS and csharp
   - All other failures seem related to nanoarrow's stream-to-file conversion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org