You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/02/09 06:30:53 UTC
[GitHub] [calcite] wojustme opened a new pull request #2713: [CALCITE-5002] SubstitutionVisitor exec mv-match fail, cause by `unused project on aggregate in the mv`
wojustme opened a new pull request #2713:
URL: https://github.com/apache/calcite/pull/2713
Link to [ISSUE-5002](https://issues.apache.org/jira/browse/CALCITE-5002)
Wrap a top calc to query, when target's top rel is calc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on pull request #2713: [CALCITE-5002] SubstitutionVisitor exec mv-match fail, cause by `unused project on aggregate in the mv`
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on pull request #2713:
URL: https://github.com/apache/calcite/pull/2713#issuecomment-1038582099
There is already an issue.
https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4376?filter=allopenissues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on a change in pull request #2713: [CALCITE-5002] SubstitutionVisitor exec mv-match fail, cause by `unused project on aggregate in the mv`
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #2713:
URL: https://github.com/apache/calcite/pull/2713#discussion_r805477769
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -449,6 +449,25 @@ protected final MaterializedViewFixture sql(String materialize,
sql(mv, query).noMat();
}
+ /**
+ * It's need be matched, unused project on aggregate in the mv, and query's rel-root is aggregate.
Review comment:
Simplified description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on pull request #2713: [CALCITE-5002] SubstitutionVisitor exec mv-match fail, cause by `unused project on aggregate in the mv`
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on pull request #2713:
URL: https://github.com/apache/calcite/pull/2713#issuecomment-1038581076
Please fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on a change in pull request #2713: [CALCITE-5002] SubstitutionVisitor exec mv-match fail, cause by `unused project on aggregate in the mv`
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #2713:
URL: https://github.com/apache/calcite/pull/2713#discussion_r805477465
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -449,6 +449,25 @@ protected final MaterializedViewFixture sql(String materialize,
sql(mv, query).noMat();
}
+ /**
+ * It's need be matched, unused project on aggregate in the mv, and query's rel-root is aggregate.
+ */
+ @Test void testAggregate7() {
Review comment:
More tests are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org