[GitHub] rdhabalia commented on a change in pull request #2296: REST and CLI to get function metrics in json for monitoring

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #2296: REST and CLI to get function metrics in json for monitoring
URL: https://github.com/apache/incubator-pulsar/pull/2296#discussion_r207615477
 
 

 ##########
 File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Functions.java
 ##########
 @@ -259,4 +260,11 @@
      * @throws PulsarAdminException 
      */
     List<WorkerInfo> getCluster() throws PulsarAdminException;
+    
+    /**
+     * Get function worker metrics
+     * @return
+     * @throws PulsarAdminException 
+     */
+    Metrics getMetrics() throws PulsarAdminException;
 
 Review comment:
   same metrics which is being exposed on `/metrics` endpoint for prometheus but it will be in json format. it will be used by our non-prometheus monitoring system to aggregate all functions-metrics owned  by the worker.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services