You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/10/13 05:40:55 UTC
Review Request 39258: Add filesystem isolator with command executor
test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jiang Yan Xu.
Repository: mesos
Description
-------
Add filesystem isolator with command executor test.
Diffs
-----
src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
src/slave/containerizer/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
src/slave/containerizer/provisioner/provisioner.cpp 30a85a52ee5986c6e1652edfd08ae881280b23ab
src/tests/containerizer/filesystem_isolator_tests.cpp 1e332e0d36ac2812456514aa030f995b3a07dca1
src/tests/containerizer/store.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/39258/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review102393
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38900, 39258]
All tests passed.
- Mesos ReviewBot
On Oct. 13, 2015, 3:40 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 3:40 a.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
> src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
> src/slave/containerizer/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
> src/slave/containerizer/provisioner/provisioner.cpp 30a85a52ee5986c6e1652edfd08ae881280b23ab
> src/tests/containerizer/filesystem_isolator_tests.cpp 1e332e0d36ac2812456514aa030f995b3a07dca1
> src/tests/containerizer/store.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Timothy Chen <tn...@apache.org>.
> On Nov. 3, 2015, 1:30 a.m., Jie Yu wrote:
> > src/tests/containerizer/filesystem_isolator_tests.cpp, line 286
> > <https://reviews.apache.org/r/39258/diff/3/?file=1114147#file1114147line286>
> >
> > any reason you use 'copy'. Can we do bind to speed up tests?
it failed when the filesystem isolator tries to mkdir sandbox
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104842
-----------------------------------------------------------
On Nov. 2, 2015, 7:05 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:05 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Timothy Chen <tn...@apache.org>.
> On Nov. 3, 2015, 1:30 a.m., Jie Yu wrote:
> > src/tests/containerizer/filesystem_isolator_tests.cpp, line 286
> > <https://reviews.apache.org/r/39258/diff/3/?file=1114147#file1114147line286>
> >
> > any reason you use 'copy'. Can we do bind to speed up tests?
>
> Timothy Chen wrote:
> it failed when the filesystem isolator tries to mkdir sandbox
>
> Timothy Chen wrote:
> i think alternatifely i can also let Rootfs clasd create a sandbox mount point too
I tried to use BindBackend, but it then failed to create mount point for the old root in the /tmp directory of the new root in fs.cpp as Bind simply made the whole filesystem read-only. I think I'll use Copy for now.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104842
-----------------------------------------------------------
On Nov. 2, 2015, 7:05 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:05 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Timothy Chen <tn...@apache.org>.
> On Nov. 3, 2015, 1:30 a.m., Jie Yu wrote:
> > src/tests/containerizer/filesystem_isolator_tests.cpp, line 286
> > <https://reviews.apache.org/r/39258/diff/3/?file=1114147#file1114147line286>
> >
> > any reason you use 'copy'. Can we do bind to speed up tests?
>
> Timothy Chen wrote:
> it failed when the filesystem isolator tries to mkdir sandbox
i think alternatifely i can also let Rootfs clasd create a sandbox mount point too
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104842
-----------------------------------------------------------
On Nov. 2, 2015, 7:05 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:05 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104842
-----------------------------------------------------------
Have you updated the Makefile since provisioner.hpp is removed in this patch?
src/tests/containerizer/filesystem_isolator_tests.cpp (lines 119 - 124)
<https://reviews.apache.org/r/39258/#comment163107>
Can we just use Backend::create(flags) instead?
src/tests/containerizer/filesystem_isolator_tests.cpp (line 281)
<https://reviews.apache.org/r/39258/#comment163110>
any reason you use 'copy'. Can we do bind to speed up tests?
src/tests/containerizer/filesystem_isolator_tests.cpp (lines 319 - 327)
<https://reviews.apache.org/r/39258/#comment163111>
I think we can leverage the test utility `createTask` here to create the command line task.
- Jie Yu
On Nov. 2, 2015, 7:05 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:05 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104781
-----------------------------------------------------------
Bad patch!
Reviews applied: [39719, 39866, 38900, 39868, 39869, 39258]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.26.0"; then find "mesos-0.26.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-0.26.0" || { sleep 5 && rm -rf "mesos-0.26.0"; }; else :; fi
test -d "mesos-0.26.0" || mkdir "mesos-0.26.0"
(cd 3rdparty && make top_distdir=../mesos-0.26.0 distdir=../mesos-0.26.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess && make top_distdir=../../mesos-0.26.0 distdir=../../mesos-0.26.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.26.0/3rdparty/libprocess" || mkdir "../../mesos-0.26.0/3rdparty/libprocess"
(cd 3rdparty && make top_distdir=../../../mesos-0.26.0 distdir=../../../mesos-0.26.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout && make top_distdir=../../../../mesos-0.26.0 distdir=../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout" || mkdir "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout"
(cd include && make top_distdir=../../../../../mesos-0.26.0 distdir=../../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n ":" \
|| find "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh -c -m a+r {} {} \; \
|| chmod -R a+r "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout"
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd include && make top_distdir=../../../mesos-0.26.0 distdir=../../../mesos-0.26.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n ":" \
|| find "../../mesos-0.26.0/3rdparty/libprocess" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh -c -m a+r {} {} \; \
|| chmod -R a+r "../../mesos-0.26.0/3rdparty/libprocess"
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src && make top_distdir=../mesos-0.26.0 distdir=../mesos-0.26.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** No rule to make target `tests/containerizer/provisioner.hpp', needed by `distdir'. Stop.
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
- Mesos ReviewBot
On Nov. 2, 2015, 7:05 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:05 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 2:09 a.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Repository: mesos
Description
-------
Add filesystem isolator with command executor test.
Diffs (updated)
-----
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
Diff: https://reviews.apache.org/r/39258/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review105143
-----------------------------------------------------------
Ship it!
src/tests/containerizer/filesystem_isolator_tests.cpp (line 316)
<https://reviews.apache.org/r/39258/#comment163545>
remove extra space after `-d` and add a space after `+`
- Jie Yu
On Nov. 4, 2015, 9:04 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 9:04 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
> src/tests/containerizer/rootfs.hpp 56a205f7c18318ab9e99f4bb8cb969ba3302baea
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 9:04 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Repository: mesos
Description
-------
Add filesystem isolator with command executor test.
Diffs (updated)
-----
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
src/tests/containerizer/rootfs.hpp 56a205f7c18318ab9e99f4bb8cb969ba3302baea
Diff: https://reviews.apache.org/r/39258/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 7:05 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Repository: mesos
Description
-------
Add filesystem isolator with command executor test.
Diffs (updated)
-----
src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
Diff: https://reviews.apache.org/r/39258/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review104643
-----------------------------------------------------------
Bad patch!
Reviews applied: [39719, 38900, 39258]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.26.0"; then find "mesos-0.26.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-0.26.0" || { sleep 5 && rm -rf "mesos-0.26.0"; }; else :; fi
test -d "mesos-0.26.0" || mkdir "mesos-0.26.0"
(cd 3rdparty && make top_distdir=../mesos-0.26.0 distdir=../mesos-0.26.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess && make top_distdir=../../mesos-0.26.0 distdir=../../mesos-0.26.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.26.0/3rdparty/libprocess" || mkdir "../../mesos-0.26.0/3rdparty/libprocess"
(cd 3rdparty && make top_distdir=../../../mesos-0.26.0 distdir=../../../mesos-0.26.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout && make top_distdir=../../../../mesos-0.26.0 distdir=../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout" || mkdir "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout"
(cd include && make top_distdir=../../../../../mesos-0.26.0 distdir=../../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n ":" \
|| find "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh -c -m a+r {} {} \; \
|| chmod -R a+r "../../../../mesos-0.26.0/3rdparty/libprocess/3rdparty/stout"
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd include && make top_distdir=../../../mesos-0.26.0 distdir=../../../mesos-0.26.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n ":" \
|| find "../../mesos-0.26.0/3rdparty/libprocess" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh -c -m a+r {} {} \; \
|| chmod -R a+r "../../mesos-0.26.0/3rdparty/libprocess"
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src && make top_distdir=../mesos-0.26.0 distdir=../mesos-0.26.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** No rule to make target `tests/containerizer/provisioner.hpp', needed by `distdir'. Stop.
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
- Mesos ReviewBot
On Oct. 31, 2015, 5:58 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2015, 5:58 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
> src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
> src/slave/containerizer/mesos/provisioner/provisioner.cpp e99c1c9876b836be5d3efcef7408b5ed01d8984e
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
> src/tests/containerizer/store.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/
-----------------------------------------------------------
(Updated Oct. 31, 2015, 5:58 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Repository: mesos
Description
-------
Add filesystem isolator with command executor test.
Diffs (updated)
-----
src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085
src/slave/containerizer/mesos/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
src/slave/containerizer/mesos/provisioner/provisioner.cpp e99c1c9876b836be5d3efcef7408b5ed01d8984e
src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
src/tests/containerizer/provisioner.hpp 507e1413470ef4f36ead657203073115d5324bef
src/tests/containerizer/store.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/39258/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39258: Add filesystem isolator with command
executor test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review102697
-----------------------------------------------------------
src/slave/containerizer/provisioner/provisioner.hpp (line 101)
<https://reviews.apache.org/r/39258/#comment160452>
Can you move this comment up at the class level.
```
// Expose this class for testing only.
```
src/tests/containerizer/filesystem_isolator_tests.cpp (lines 100 - 102)
<https://reviews.apache.org/r/39258/#comment160460>
Instead of doing that, can we combine two 'createContainerizer' methods into one? In other words, let's always use the real provisioner with TestStore. Let's still keep the existing createContainerizer interface (i.e., taking a hashmap from image name to rootfs path).
src/tests/containerizer/filesystem_isolator_tests.cpp (lines 280 - 306)
<https://reviews.apache.org/r/39258/#comment160461>
You should be able to get rid of the logics here by doing what I suggested above.
- Jie Yu
On Oct. 13, 2015, 3:40 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 3:40 a.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add filesystem isolator with command executor test.
>
>
> Diffs
> -----
>
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
> src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
> src/slave/containerizer/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
> src/slave/containerizer/provisioner/provisioner.cpp 30a85a52ee5986c6e1652edfd08ae881280b23ab
> src/tests/containerizer/filesystem_isolator_tests.cpp 1e332e0d36ac2812456514aa030f995b3a07dca1
> src/tests/containerizer/store.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39258/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>