You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by Peng Zheng <pe...@apache.org> on 2023/05/04 10:17:58 UTC
Re: GitHub notifications format
On 4/28/23 21:12, Pepijn Noltes wrote:
> Hi Roy,
>
> On Thu, Apr 27, 2023 at 1:51 PM Roy Lenferink<rl...@apache.org> wrote:
>> Looking at [1] the possibility now exists for projects to tweak the format
>> of
>> the GitHub notifications sent to the project its mailing list.
>>
>> I just opened PR #528 [1] as a starting point for this. I copied this from
>> the
>> plc4x project [3] (pointed to by Christofer Dutz).
>>
>> If anyone has feedback, feel free to chime in.
>>
>> Roy
>>
>> [1]
>> https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-CustomsubjectlinesforGitHubevents
>> [2]https://github.com/apache/celix/pull/528
>> [3]
>> https://github.com/apache/plc4x/blob/a1c99f2045e01668e1d4b63377e840839b928610/.asf.yaml#L61-L71
> I saw the PR and this looks good to me. Thanks for picking this up.
>
> Pepijn
Thanks. It indeed increases the usefulness of our mailing list.
I observed that LGTM never appears in the list. Any body knows why?
--
Peng Zheng
Re: GitHub notifications format
Posted by Peng Zheng <pe...@apache.org>.
On 5/9/23 00:47, Roy Lenferink wrote:
> I also had a quick check and can't find your LGTM comment [1]
> on the mailing list.
>
> This seems like something that maybe INFRA (or the mailing list
> provider which is contracted by INFRA) should be made aware of.
>
> Raising issues is possible via Jira [2] where committers can sign-in
> with their Apache account.
>
> Do you want to do this Peng?
>
> [1] https://github.com/apache/celix/pull/528#pullrequestreview-1403835174
> [2] https://issues.apache.org/jira/browse/INFRA
I have raised an issue: https://issues.apache.org/jira/browse/INFRA-24575
Thanks for the instruction.
>
> Roy
>
> Op vr 5 mei 2023 om 03:27 schreef Peng Zheng <pe...@apache.org>:
>
>> On 5/4/23 21:40, Pepijn Noltes wrote:
>>> Do you mean my reaction to the "GitHub notifications format" mail thread?
>>> I do see my reaction in the mailinglist arhives:
>>> https://lists.apache.org/thread/zl6scksn70fhmg0ohzmw4o63h6s0ny3x
>> I mean there is no LGTM in any pull request thread, e.g. [PR]
>> Feature/celix err (celix).
>>
>> I also notice that we only have "Re: [PR] Add unit tests for rsa_shm and
>> rsa_json_rpc (celix)" without "[PR] Add unit tests for rsa_shm and
>> rsa_json_rpc (celix)".
>>
>> --
>> Peng Zheng
>>
>>
--
Peng Zheng
Re: GitHub notifications format
Posted by Roy Lenferink <rl...@apache.org>.
I also had a quick check and can't find your LGTM comment [1]
on the mailing list.
This seems like something that maybe INFRA (or the mailing list
provider which is contracted by INFRA) should be made aware of.
Raising issues is possible via Jira [2] where committers can sign-in
with their Apache account.
Do you want to do this Peng?
[1] https://github.com/apache/celix/pull/528#pullrequestreview-1403835174
[2] https://issues.apache.org/jira/browse/INFRA
Roy
Op vr 5 mei 2023 om 03:27 schreef Peng Zheng <pe...@apache.org>:
> On 5/4/23 21:40, Pepijn Noltes wrote:
> > Do you mean my reaction to the "GitHub notifications format" mail thread?
> > I do see my reaction in the mailinglist arhives:
> > https://lists.apache.org/thread/zl6scksn70fhmg0ohzmw4o63h6s0ny3x
>
> I mean there is no LGTM in any pull request thread, e.g. [PR]
> Feature/celix err (celix).
>
> I also notice that we only have "Re: [PR] Add unit tests for rsa_shm and
> rsa_json_rpc (celix)" without "[PR] Add unit tests for rsa_shm and
> rsa_json_rpc (celix)".
>
> --
> Peng Zheng
>
>
Re: GitHub notifications format
Posted by Peng Zheng <pe...@apache.org>.
On 5/4/23 21:40, Pepijn Noltes wrote:
> Do you mean my reaction to the "GitHub notifications format" mail thread?
> I do see my reaction in the mailinglist arhives:
> https://lists.apache.org/thread/zl6scksn70fhmg0ohzmw4o63h6s0ny3x
I mean there is no LGTM in any pull request thread, e.g. [PR]
Feature/celix err (celix).
I also notice that we only have "Re: [PR] Add unit tests for rsa_shm and
rsa_json_rpc (celix)" without "[PR] Add unit tests for rsa_shm and
rsa_json_rpc (celix)".
--
Peng Zheng
Re: GitHub notifications format
Posted by Pepijn Noltes <pe...@gmail.com>.
On Thu, May 4, 2023 at 12:18 PM Peng Zheng <pe...@apache.org> wrote:
>
> On 4/28/23 21:12, Pepijn Noltes wrote:
>
> Hi Roy,
>
> On Thu, Apr 27, 2023 at 1:51 PM Roy Lenferink <rl...@apache.org> wrote:
>
> Looking at [1] the possibility now exists for projects to tweak the format
> of
> the GitHub notifications sent to the project its mailing list.
>
> I just opened PR #528 [1] as a starting point for this. I copied this from
> the
> plc4x project [3] (pointed to by Christofer Dutz).
>
> If anyone has feedback, feel free to chime in.
>
> Roy
>
> [1]
> https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-CustomsubjectlinesforGitHubevents
> [2] https://github.com/apache/celix/pull/528
> [3]
> https://github.com/apache/plc4x/blob/a1c99f2045e01668e1d4b63377e840839b928610/.asf.yaml#L61-L71
>
> I saw the PR and this looks good to me. Thanks for picking this up.
>
> Pepijn
>
> Thanks. It indeed increases the usefulness of our mailing list.
>
> I observed that LGTM never appears in the list. Any body knows why?
Do you mean my reaction to the "GitHub notifications format" mail thread?
I do see my reaction in the mailinglist arhives:
https://lists.apache.org/thread/zl6scksn70fhmg0ohzmw4o63h6s0ny3x
>
> --
> Peng Zheng