You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 10:49:52 UTC
[GitHub] [airflow] pragyak412 opened a new pull request, #23116: TrinoHook add authentication via JWT token and Impersonation
pragyak412 opened a new pull request, #23116:
URL: https://github.com/apache/airflow/pull/23116
closes: https://github.com/apache/airflow/issues/18969
This change introduces the authentication method via JWT and also the possibility to impersonate a DAG owner.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pragyak412 commented on pull request #23116: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
pragyak412 commented on PR #23116:
URL: https://github.com/apache/airflow/pull/23116#issuecomment-1108081332
@mik-laj Please review it whenever you have time. Let me know if there is any suggestion.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #23116: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
eladkal merged PR #23116:
URL: https://github.com/apache/airflow/pull/23116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #23116: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #23116:
URL: https://github.com/apache/airflow/pull/23116#issuecomment-1104200692
You'll need to rebase
failing docker tests were fixed in https://github.com/apache/airflow/pull/23122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pragyak412 commented on pull request #23116: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
pragyak412 commented on PR #23116:
URL: https://github.com/apache/airflow/pull/23116#issuecomment-1105617693
@
> You'll need to rebase failing docker tests were fixed in #23122
@eladkal can you please review it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23116: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23116:
URL: https://github.com/apache/airflow/pull/23116#issuecomment-1106672450
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23116: TrinoHook add authentication via JWT token and Impersonation
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23116:
URL: https://github.com/apache/airflow/pull/23116#issuecomment-1119959261
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org