[GitHub] [flink] fsk119 commented on pull request #15018: [FLINK-21460][table api] Use Configuration to create TableEnvironment

[GitBox <gi...@apache.org>]

fsk119 commented on pull request #15018:
URL: https://github.com/apache/flink/pull/15018#issuecomment-787590898


   Hi @twalthr . Thanks for your quick and detailed feedbacks. I am not sure whether it's a good idea to use validation to check the configuration. The main concern is that the error message is away from the code where problem happens.  For example, users may execute the file as follow:
   
   ```
   // illegal modification
   tEnv.getConfig().getConfiguration().setString("planner.type", "old");
   // other codes e.g. 
   tEnv.getConfig().getConfiguration().setString("pipeline.auto-watermark-interval", "100");
   ...
   // do insert and get the error 
   tEnv.executeSql("insert into ...");
   ```
   
   What about make `TableConfiguration` as an inner class of `TableConfig`? Users don't need to care about which `Configuration` they use. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org