You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/05/13 20:32:51 UTC
Review Request 34175: Remove temporary api fields for obtaining
kerberos descriptors for stacks and stack services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34175/
-----------------------------------------------------------
Review request for Ambari, Emil Anca, John Speidel, and Tom Beerbower.
Bugs: AMBARI-9030
https://issues.apache.org/jira/browse/AMBARI-9030
Repository: ambari
Description
-------
Remove the temporary kerberos_descriptor fields in the StackVersion and StackService endpoints. These have been replaced with the new artifact/kerberos_descriptor endpoints introduced in AMBARI-9028.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java c80913e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java ca66819
ambari-server/src/main/resources/properties.json 38fbb65
Diff: https://reviews.apache.org/r/34175/diff/
Testing
-------
Manually tested to verify that the temporary kerberos_descriptor fields were removed and to ensure enabling Kerberos still worked due to the API changes.
Thanks,
Robert Levas
Re: Review Request 34175: Remove temporary api fields for obtaining
kerberos descriptors for stacks and stack services
Posted by Robert Levas <rl...@hortonworks.com>.
> On May 13, 2015, 2:54 p.m., Tom Beerbower wrote:
> > Looks good, as long as nobody is currently using the 'StackServices/kerberos_descriptor' property.
I tested to make sure of this. We are good. :)
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34175/#review83654
-----------------------------------------------------------
On May 13, 2015, 2:32 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34175/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 2:32 p.m.)
>
>
> Review request for Ambari, Emil Anca, John Speidel, and Tom Beerbower.
>
>
> Bugs: AMBARI-9030
> https://issues.apache.org/jira/browse/AMBARI-9030
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove the temporary kerberos_descriptor fields in the StackVersion and StackService endpoints. These have been replaced with the new artifact/kerberos_descriptor endpoints introduced in AMBARI-9028.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java c80913e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java ca66819
> ambari-server/src/main/resources/properties.json 38fbb65
>
> Diff: https://reviews.apache.org/r/34175/diff/
>
>
> Testing
> -------
>
> Manually tested to verify that the temporary kerberos_descriptor fields were removed and to ensure enabling Kerberos still worked due to the API changes.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 34175: Remove temporary api fields for obtaining
kerberos descriptors for stacks and stack services
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34175/#review83654
-----------------------------------------------------------
Ship it!
Looks good, as long as nobody is currently using the 'StackServices/kerberos_descriptor' property.
- Tom Beerbower
On May 13, 2015, 6:32 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34175/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 6:32 p.m.)
>
>
> Review request for Ambari, Emil Anca, John Speidel, and Tom Beerbower.
>
>
> Bugs: AMBARI-9030
> https://issues.apache.org/jira/browse/AMBARI-9030
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove the temporary kerberos_descriptor fields in the StackVersion and StackService endpoints. These have been replaced with the new artifact/kerberos_descriptor endpoints introduced in AMBARI-9028.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java c80913e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java ca66819
> ambari-server/src/main/resources/properties.json 38fbb65
>
> Diff: https://reviews.apache.org/r/34175/diff/
>
>
> Testing
> -------
>
> Manually tested to verify that the temporary kerberos_descriptor fields were removed and to ensure enabling Kerberos still worked due to the API changes.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 34175: Remove temporary api fields for obtaining
kerberos descriptors for stacks and stack services
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34175/#review83658
-----------------------------------------------------------
Ship it!
Ship It!
- John Speidel
On May 13, 2015, 6:32 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34175/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 6:32 p.m.)
>
>
> Review request for Ambari, Emil Anca, John Speidel, and Tom Beerbower.
>
>
> Bugs: AMBARI-9030
> https://issues.apache.org/jira/browse/AMBARI-9030
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove the temporary kerberos_descriptor fields in the StackVersion and StackService endpoints. These have been replaced with the new artifact/kerberos_descriptor endpoints introduced in AMBARI-9028.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java c80913e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java ca66819
> ambari-server/src/main/resources/properties.json 38fbb65
>
> Diff: https://reviews.apache.org/r/34175/diff/
>
>
> Testing
> -------
>
> Manually tested to verify that the temporary kerberos_descriptor fields were removed and to ensure enabling Kerberos still worked due to the API changes.
>
>
> Thanks,
>
> Robert Levas
>
>