[GitHub] [iceberg] szehon-ho edited a comment on pull request #4050: [WIP] Add FileIOMetrics to enable reporting of read/write metrics

[GitBox <gi...@apache.org>]

szehon-ho edited a comment on pull request #4050:
URL: https://github.com/apache/iceberg/pull/4050#issuecomment-1034226007


   Actually thinking on the second point , the current API is probably fine if you are implementing a generic metrics system, but the first implementation using Hadoop's FileMetric class is not a generic API.  So maybe this could be just be clarified that HadoopFileIOMetrics works only with S3FileIO (as it expects the exact metrics name/type that S3FileIO calls with), and we should not put it in core


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org