You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "lengmoXXL (via GitHub)" <gi...@apache.org> on 2024/01/03 05:20:43 UTC
[PR] Fix scoped_refptr leave ptr_ uninit when move construct by nullptr (brpc)
lengmoXXL opened a new pull request, #2491:
URL: https://github.com/apache/brpc/pull/2491
### What problem does this PR solve?
Issue Number:
Problem Summary:
scoped_refptr 使用 nullptr 移动构造时会导致 ptr_ 未初始化，从而有可能导致内存问题
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响): 无
- Breaking backward compatibility(向后兼容性): 无
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix scoped_refptr leave ptr_ uninit when move construct by nullptr (brpc)
Posted by "lengmoXXL (via GitHub)" <gi...@apache.org>.
lengmoXXL commented on PR #2491:
URL: https://github.com/apache/brpc/pull/2491#issuecomment-1874862827
该问题由 pr #2284 引入
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix scoped_refptr leave ptr_ uninit when move construct by nullptr (brpc)
Posted by "TousakaRin (via GitHub)" <gi...@apache.org>.
TousakaRin merged PR #2491:
URL: https://github.com/apache/brpc/pull/2491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix scoped_refptr leave ptr_ uninit when move construct by nullptr (brpc)
Posted by "TousakaRin (via GitHub)" <gi...@apache.org>.
TousakaRin commented on code in PR #2491:
URL: https://github.com/apache/brpc/pull/2491#discussion_r1440092282
##########
src/butil/memory/ref_counted.h:
##########
@@ -285,21 +285,19 @@ class scoped_refptr {
ptr_->AddRef();
}
- scoped_refptr(scoped_refptr<T>&& r) noexcept {
+ scoped_refptr(scoped_refptr<T>&& r) noexcept : ptr_(r.ptr_) {
if (r.ptr_){
Review Comment:
这个判断去掉，直接让 r.ptr_ = nullptr; 是否更清晰一些。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix scoped_refptr leave ptr_ uninit when move construct by nullptr (brpc)
Posted by "lengmoXXL (via GitHub)" <gi...@apache.org>.
lengmoXXL commented on code in PR #2491:
URL: https://github.com/apache/brpc/pull/2491#discussion_r1440105137
##########
src/butil/memory/ref_counted.h:
##########
@@ -285,21 +285,19 @@ class scoped_refptr {
ptr_->AddRef();
}
- scoped_refptr(scoped_refptr<T>&& r) noexcept {
+ scoped_refptr(scoped_refptr<T>&& r) noexcept : ptr_(r.ptr_) {
if (r.ptr_){
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org