You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gary Kind (JIRA)" <de...@myfaces.apache.org> on 2007/09/17 22:25:44 UTC
[jira] Created: (TRINIDAD-718) MenuNode.getLabel() does not handle
complex EL expressions correctly
MenuNode.getLabel() does not handle complex EL expressions correctly
--------------------------------------------------------------------
Key: TRINIDAD-718
URL: https://issues.apache.org/jira/browse/TRINIDAD-718
Project: MyFaces Trinidad
Issue Type: Bug
Reporter: Gary Kind
Private method _evalElStr(), which is called from MenuNode.getLabel(), in the case of a Resource Bundle EL expression, is used to insert a Unique Id in the EL expression to indentify the correct Resoure Bundle. If the EL expression is not a Resource Bundle, the EL String is just passed on to be evaluated. In the latter case, _bundleKey is null which seems to give the "replaceFirst" method of java.lang.String problems. This results in an NPE, where the documentation says it should result in a PatternSyntaxException. Checking for a null _bundleKey solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-718) MenuNode.getLabel() does not handle
complex EL expressions correctly
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman updated TRINIDAD-718:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> MenuNode.getLabel() does not handle complex EL expressions correctly
> --------------------------------------------------------------------
>
> Key: TRINIDAD-718
> URL: https://issues.apache.org/jira/browse/TRINIDAD-718
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gary Kind
> Attachments: 122Branch.patch, trunk.patch, trunk2.patch
>
>
> Private method _evalElStr(), which is called from MenuNode.getLabel(), in the case of a Resource Bundle EL expression, is used to insert a Unique Id in the EL expression to indentify the correct Resoure Bundle. If the EL expression is not a Resource Bundle, the EL String is just passed on to be evaluated. In the latter case, _bundleKey is null which seems to give the "replaceFirst" method of java.lang.String problems. This results in an NPE, where the documentation says it should result in a PatternSyntaxException. Checking for a null _bundleKey solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-718) MenuNode.getLabel() does not handle
complex EL expressions correctly
Posted by "Gary Kind (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Kind updated TRINIDAD-718:
-------------------------------
Status: Patch Available (was: Open)
> MenuNode.getLabel() does not handle complex EL expressions correctly
> --------------------------------------------------------------------
>
> Key: TRINIDAD-718
> URL: https://issues.apache.org/jira/browse/TRINIDAD-718
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gary Kind
>
> Private method _evalElStr(), which is called from MenuNode.getLabel(), in the case of a Resource Bundle EL expression, is used to insert a Unique Id in the EL expression to indentify the correct Resoure Bundle. If the EL expression is not a Resource Bundle, the EL String is just passed on to be evaluated. In the latter case, _bundleKey is null which seems to give the "replaceFirst" method of java.lang.String problems. This results in an NPE, where the documentation says it should result in a PatternSyntaxException. Checking for a null _bundleKey solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-718) MenuNode.getLabel() does not
handle complex EL expressions correctly
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528575 ]
Jeanne Waldman commented on TRINIDAD-718:
-----------------------------------------
Committed trunk2.patch to trunk.
svn 577069
> MenuNode.getLabel() does not handle complex EL expressions correctly
> --------------------------------------------------------------------
>
> Key: TRINIDAD-718
> URL: https://issues.apache.org/jira/browse/TRINIDAD-718
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gary Kind
> Attachments: 122Branch.patch, trunk.patch, trunk2.patch
>
>
> Private method _evalElStr(), which is called from MenuNode.getLabel(), in the case of a Resource Bundle EL expression, is used to insert a Unique Id in the EL expression to indentify the correct Resoure Bundle. If the EL expression is not a Resource Bundle, the EL String is just passed on to be evaluated. In the latter case, _bundleKey is null which seems to give the "replaceFirst" method of java.lang.String problems. This results in an NPE, where the documentation says it should result in a PatternSyntaxException. Checking for a null _bundleKey solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.