You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Sergey Chugunov <se...@gmail.com> on 2017/05/23 08:44:33 UTC

IGNITE-5124 is ready for review

Hello Igniters,

I implemented UX improvements for MemoryMetrics and added/clarified some
documentation to public API.

Please find changes under pull request here
<https://github.com/apache/ignite/pull/1988>, for discussions feel free to
leave comments in upsource review
<http://reviews.ignite.apache.org/ignite/review/IGNT-CR-184>.

Thanks,
Sergey.

Re: IGNITE-5124 is ready for review

Posted by Denis Magda <dm...@apache.org>.
Sergey,

Looks good to me. Please ask Alex G. to review the implementation part. I’ve taken look at the interfaces only.

—
Denis

> On May 24, 2017, at 9:04 AM, Sergey Chugunov <se...@gmail.com> wrote:
> 
> Denis,
> 
> Thanks for your comments, I've addressed them and pushed changes.
> 
> Could you please review one more time?
> 
> Thanks,
> Sergey.
> 
> On Wed, May 24, 2017 at 12:20 AM, Denis Magda <dm...@apache.org> wrote:
> 
>> Sergey,
>> 
>> Thanks, reviewed and left the notes in the upsource.
>> 
>> —
>> Denis
>> 
>>> On May 23, 2017, at 1:44 AM, Sergey Chugunov <se...@gmail.com>
>> wrote:
>>> 
>>> Hello Igniters,
>>> 
>>> I implemented UX improvements for MemoryMetrics and added/clarified some
>>> documentation to public API.
>>> 
>>> Please find changes under pull request here
>>> <https://github.com/apache/ignite/pull/1988>, for discussions feel free
>> to
>>> leave comments in upsource review
>>> <http://reviews.ignite.apache.org/ignite/review/IGNT-CR-184>.
>>> 
>>> Thanks,
>>> Sergey.
>> 
>>

Re: IGNITE-5124 is ready for review

Posted by Sergey Chugunov <se...@gmail.com>.
Denis,

Thanks for your comments, I've addressed them and pushed changes.

Could you please review one more time?

Thanks,
Sergey.

On Wed, May 24, 2017 at 12:20 AM, Denis Magda <dm...@apache.org> wrote:

> Sergey,
>
> Thanks, reviewed and left the notes in the upsource.
>
> —
> Denis
>
> > On May 23, 2017, at 1:44 AM, Sergey Chugunov <se...@gmail.com>
> wrote:
> >
> > Hello Igniters,
> >
> > I implemented UX improvements for MemoryMetrics and added/clarified some
> > documentation to public API.
> >
> > Please find changes under pull request here
> > <https://github.com/apache/ignite/pull/1988>, for discussions feel free
> to
> > leave comments in upsource review
> > <http://reviews.ignite.apache.org/ignite/review/IGNT-CR-184>.
> >
> > Thanks,
> > Sergey.
>
>

Re: IGNITE-5124 is ready for review

Posted by Denis Magda <dm...@apache.org>.
Sergey,

Thanks, reviewed and left the notes in the upsource.

—
Denis

> On May 23, 2017, at 1:44 AM, Sergey Chugunov <se...@gmail.com> wrote:
> 
> Hello Igniters,
> 
> I implemented UX improvements for MemoryMetrics and added/clarified some
> documentation to public API.
> 
> Please find changes under pull request here
> <https://github.com/apache/ignite/pull/1988>, for discussions feel free to
> leave comments in upsource review
> <http://reviews.ignite.apache.org/ignite/review/IGNT-CR-184>.
> 
> Thanks,
> Sergey.