You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/07 16:33:12 UTC
[GitHub] [superset] yardz opened a new pull request #13860: test: ShareMenuItems
yardz opened a new pull request #13860:
URL: https://github.com/apache/superset/pull/13860
### SUMMARY
Tests for component ShareMenuItems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (d9e3b50) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d9e3b50 differs from pull request most recent head 3871b3f. Consider uploading reports for the commit 3871b3f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
=======================================
Coverage 77.33% 77.34%
=======================================
Files 935 936 +1
Lines 47278 47294 +16
Branches 5883 5884 +1
=======================================
+ Hits 36564 36580 +16
Misses 10570 10570
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.84% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...d/src/dashboard/components/menu/ShareMenuItems.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMudHN4) | `25.00% <0.00%> (-20.46%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...3871b3f](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-810573134
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (62e9630) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.49%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 62e9630 differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
- Coverage 77.33% 76.84% -0.50%
==========================================
Files 935 939 +4
Lines 47278 47921 +643
Branches 5883 6139 +256
==========================================
+ Hits 36564 36824 +260
- Misses 10570 10954 +384
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.76% <ø> (-0.31%)` | :arrow_down: |
| javascript | `64.72% <ø> (+0.97%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-54.55%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.30% <0.00%> (-22.35%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `76.00% <0.00%> (-13.48%)` | :arrow_down: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `74.24% <0.00%> (-10.95%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `6.46% <0.00%> (-2.77%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <0.00%> (-1.38%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <0.00%> (-0.65%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz closed pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
yardz closed pull request #13860:
URL: https://github.com/apache/superset/pull/13860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-815149132
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13860:
URL: https://github.com/apache/superset/pull/13860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13860:
URL: https://github.com/apache/superset/pull/13860#discussion_r605271589
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
Review comment:
```suggestion
delete window.location;
fetchMock.post(
'http://localhost/r/shortner/',
{ body: 'http://localhost:8088/r/3' },
{
sendAsJson: false,
},
);
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
+});
+beforeEach(() => {
Review comment:
```suggestion
beforeEach(() => {
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
Review comment:
```suggestion
const { location } = window;
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
+});
+beforeEach(() => {
+ jest.clearAllMocks();
+ fetchMock.post(
+ 'http://localhost/r/shortner/',
+ { body: 'http://localhost:8088/r/3' },
+ {
+ sendAsJson: false,
+ overwriteRoutes: true,
+ },
+ );
+ window.location = {
+ href: '',
+ } as any;
+});
+afterAll((): void => {
+ window.location = location;
+});
+
+test('Should render menu items', () => {
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+ expect(
+ screen.getByRole('menuitem', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+});
+
+test('Clicking on "Copy dashboard URL" and have success', async () => {
+ spy.mockResolvedValue(undefined);
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(0);
+ expect(props.addSuccessToast).toBeCalledTimes(0);
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+
+ userEvent.click(screen.getByRole('button', { name: 'Copy dashboard URL' }));
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(1);
+ expect(spy).toBeCalledWith('http://localhost:8088/r/3');
+ expect(props.addSuccessToast).toBeCalledTimes(1);
+ expect(props.addSuccessToast).toBeCalledWith('Copied to clipboard!');
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+});
+
+test('Clicking on "Copy dashboard URL" and have fail', async () => {
Review comment:
```suggestion
test('Click on "Copy dashboard URL" and fail', async () => {
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
+});
+beforeEach(() => {
+ jest.clearAllMocks();
+ fetchMock.post(
+ 'http://localhost/r/shortner/',
+ { body: 'http://localhost:8088/r/3' },
+ {
+ sendAsJson: false,
+ overwriteRoutes: true,
+ },
+ );
+ window.location = {
+ href: '',
+ } as any;
+});
+afterAll((): void => {
+ window.location = location;
+});
+
+test('Should render menu items', () => {
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+ expect(
+ screen.getByRole('menuitem', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+});
+
+test('Clicking on "Copy dashboard URL" and have success', async () => {
+ spy.mockResolvedValue(undefined);
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(0);
+ expect(props.addSuccessToast).toBeCalledTimes(0);
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+
+ userEvent.click(screen.getByRole('button', { name: 'Copy dashboard URL' }));
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(1);
+ expect(spy).toBeCalledWith('http://localhost:8088/r/3');
+ expect(props.addSuccessToast).toBeCalledTimes(1);
+ expect(props.addSuccessToast).toBeCalledWith('Copied to clipboard!');
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+});
+
+test('Clicking on "Copy dashboard URL" and have fail', async () => {
+ spy.mockRejectedValue(undefined);
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(0);
+ expect(props.addSuccessToast).toBeCalledTimes(0);
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+
+ userEvent.click(screen.getByRole('button', { name: 'Copy dashboard URL' }));
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(1);
+ expect(spy).toBeCalledWith('http://localhost:8088/r/3');
+ expect(props.addSuccessToast).toBeCalledTimes(0);
+ expect(props.addDangerToast).toBeCalledTimes(1);
+ expect(props.addDangerToast).toBeCalledWith(
+ 'Sorry, your browser does not support copying.',
+ );
+ });
+});
+
+test('Clicking on "Share dashboard by email" and have success', async () => {
Review comment:
```suggestion
test('Click on "Share dashboard by email" and succeed', async () => {
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
+});
+beforeEach(() => {
+ jest.clearAllMocks();
+ fetchMock.post(
+ 'http://localhost/r/shortner/',
+ { body: 'http://localhost:8088/r/3' },
+ {
+ sendAsJson: false,
+ overwriteRoutes: true,
+ },
+ );
Review comment:
```suggestion
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
+});
+beforeEach(() => {
+ jest.clearAllMocks();
+ fetchMock.post(
+ 'http://localhost/r/shortner/',
+ { body: 'http://localhost:8088/r/3' },
+ {
+ sendAsJson: false,
+ overwriteRoutes: true,
+ },
+ );
+ window.location = {
+ href: '',
+ } as any;
+});
+afterAll((): void => {
+ window.location = location;
+});
+
+test('Should render menu items', () => {
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+ expect(
+ screen.getByRole('menuitem', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+});
+
+test('Clicking on "Copy dashboard URL" and have success', async () => {
+ spy.mockResolvedValue(undefined);
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(0);
+ expect(props.addSuccessToast).toBeCalledTimes(0);
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+
+ userEvent.click(screen.getByRole('button', { name: 'Copy dashboard URL' }));
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(1);
+ expect(spy).toBeCalledWith('http://localhost:8088/r/3');
+ expect(props.addSuccessToast).toBeCalledTimes(1);
+ expect(props.addSuccessToast).toBeCalledWith('Copied to clipboard!');
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+});
+
+test('Clicking on "Copy dashboard URL" and have fail', async () => {
+ spy.mockRejectedValue(undefined);
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(0);
+ expect(props.addSuccessToast).toBeCalledTimes(0);
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ });
+
+ userEvent.click(screen.getByRole('button', { name: 'Copy dashboard URL' }));
+
+ await waitFor(() => {
+ expect(spy).toBeCalledTimes(1);
+ expect(spy).toBeCalledWith('http://localhost:8088/r/3');
+ expect(props.addSuccessToast).toBeCalledTimes(0);
+ expect(props.addDangerToast).toBeCalledTimes(1);
+ expect(props.addDangerToast).toBeCalledWith(
+ 'Sorry, your browser does not support copying.',
+ );
+ });
+});
+
+test('Clicking on "Share dashboard by email" and have success', async () => {
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+
+ await waitFor(() => {
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ expect(window.location.href).toBe('');
+ });
+
+ userEvent.click(
+ screen.getByRole('button', { name: 'Share dashboard by email' }),
+ );
+
+ await waitFor(() => {
+ expect(props.addDangerToast).toBeCalledTimes(0);
+ expect(window.location.href).toBe(
+ 'mailto:?Subject=Superset dashboard COVID Vaccine Dashboard%20&Body=Check out this dashboard: http://localhost:8088/r/3',
+ );
+ });
+});
+
+test('Clicking on "Share dashboard by email" and have fail', async () => {
Review comment:
```suggestion
test('Click on "Share dashboard by email" and fail', async () => {
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
+});
+beforeEach(() => {
+ jest.clearAllMocks();
+ fetchMock.post(
+ 'http://localhost/r/shortner/',
+ { body: 'http://localhost:8088/r/3' },
+ {
+ sendAsJson: false,
+ overwriteRoutes: true,
+ },
+ );
+ window.location = {
+ href: '',
+ } as any;
+});
+afterAll((): void => {
Review comment:
```suggestion
afterAll((): void => {
```
##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
##########
@@ -0,0 +1,192 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { Menu } from 'src/common/components';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import * as copyTextToClipboard from 'src/utils/copy';
+import fetchMock from 'fetch-mock';
+import ShareMenuItems from '.';
+
+const spy = jest.spyOn(copyTextToClipboard, 'default');
+
+const createProps = () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ url: '/superset/dashboard/26/?preselect_filters=%7B%7D',
+ copyMenuItemTitle: 'Copy dashboard URL',
+ emailMenuItemTitle: 'Share dashboard by email',
+ emailSubject: 'Superset dashboard COVID Vaccine Dashboard',
+ emailBody: 'Check out this dashboard: ',
+});
+
+const { location } = window;
+beforeAll((): void => {
+ // @ts-ignore
+ delete window.location;
+});
+beforeEach(() => {
+ jest.clearAllMocks();
+ fetchMock.post(
+ 'http://localhost/r/shortner/',
+ { body: 'http://localhost:8088/r/3' },
+ {
+ sendAsJson: false,
+ overwriteRoutes: true,
+ },
+ );
+ window.location = {
+ href: '',
+ } as any;
+});
+afterAll((): void => {
+ window.location = location;
+});
+
+test('Should render menu items', () => {
+ const props = createProps();
+ render(
+ <Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
+ <ShareMenuItems {...props} />
+ </Menu>,
+ );
+ expect(
+ screen.getByRole('menuitem', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Copy dashboard URL' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Share dashboard by email' }),
+ ).toBeInTheDocument();
+});
+
+test('Clicking on "Copy dashboard URL" and have success', async () => {
Review comment:
```suggestion
test('Click on "Copy dashboard URL" and succeed', async () => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (d9e3b50) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.58%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d9e3b50 differs from pull request most recent head 3871b3f. Consider uploading reports for the commit 3871b3f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
- Coverage 77.33% 76.75% -0.59%
==========================================
Files 935 935
Lines 47278 47277 -1
Branches 5883 5883
==========================================
- Hits 36564 36287 -277
- Misses 10570 10824 +254
- Partials 144 166 +22
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.63% <ø> (+0.57%)` | :arrow_up: |
| javascript | `63.84% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...3871b3f](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-816449432
@yardz thank you Bruno, for the PR!
It will be great to attach the UI of each component to help testing, going forward. cc @michael-s-molina @geido
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (6e1fc94) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `1.77%`.
> The diff coverage is `82.33%`.
> :exclamation: Current head 6e1fc94 differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 79.11% +1.77%
==========================================
Files 935 937 +2
Lines 47278 47424 +146
Branches 5883 5940 +57
==========================================
+ Hits 36564 37518 +954
+ Misses 10570 9779 -791
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <67.05%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (d9e3b50) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d9e3b50 differs from pull request most recent head 3871b3f. Consider uploading reports for the commit 3871b3f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 77.36% +0.02%
==========================================
Files 935 935
Lines 47278 47278
Branches 5883 5883
==========================================
+ Hits 36564 36576 +12
+ Misses 10570 10558 -12
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (ø)` | |
| javascript | `63.84% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...3871b3f](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (ce4b51d) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `1.69%`.
> The diff coverage is `84.00%`.
> :exclamation: Current head ce4b51d differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 79.03% +1.69%
==========================================
Files 935 939 +4
Lines 47278 47626 +348
Branches 5883 5990 +107
==========================================
+ Hits 36564 37639 +1075
+ Misses 10570 9860 -710
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <66.86%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [190 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (6e1fc94) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `1.81%`.
> The diff coverage is `82.33%`.
> :exclamation: Current head 6e1fc94 differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 79.15% +1.81%
==========================================
Files 935 936 +1
Lines 47278 47408 +130
Branches 5883 5939 +56
==========================================
+ Hits 36564 37526 +962
+ Misses 10570 9755 -815
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <67.05%> (-0.03%)` | :arrow_down: |
| javascript | `68.53% <76.67%> (+4.78%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (62e9630) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.49%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 62e9630 differs from pull request most recent head 424c316. Consider uploading reports for the commit 424c316 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
- Coverage 77.33% 76.84% -0.50%
==========================================
Files 935 939 +4
Lines 47278 47921 +643
Branches 5883 6139 +256
==========================================
+ Hits 36564 36824 +260
- Misses 10570 10954 +384
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.76% <ø> (-0.31%)` | :arrow_down: |
| javascript | `64.72% <ø> (+0.97%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-54.55%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.30% <0.00%> (-22.35%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `76.00% <0.00%> (-13.48%)` | :arrow_down: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `74.24% <0.00%> (-10.95%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `6.46% <0.00%> (-2.77%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <0.00%> (-1.38%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <0.00%> (-0.65%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...424c316](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-816861926
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-810878322
@junlincc Ephemeral environment spinning up at http://52.37.202.175:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (6e1fc94) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `1.08%`.
> The diff coverage is `82.33%`.
> :exclamation: Current head 6e1fc94 differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 78.42% +1.08%
==========================================
Files 935 937 +2
Lines 47278 47424 +146
Branches 5883 5940 +57
==========================================
+ Hits 36564 37190 +626
+ Misses 10570 10076 -494
- Partials 144 158 +14
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.51% <67.85%> (-1.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [226 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (ce4b51d) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `1.36%`.
> The diff coverage is `84.00%`.
> :exclamation: Current head ce4b51d differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 78.70% +1.36%
==========================================
Files 935 939 +4
Lines 47278 47626 +348
Branches 5883 5990 +107
==========================================
+ Hits 36564 37483 +919
+ Misses 10570 10006 -564
+ Partials 144 137 -7
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.80% <66.40%> (-2.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [214 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-816127241
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (d9e3b50) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d9e3b50 differs from pull request most recent head feba3b0. Consider uploading reports for the commit feba3b0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 77.36% +0.02%
==========================================
Files 935 935
Lines 47278 47278
Branches 5883 5883
==========================================
+ Hits 36564 36576 +12
+ Misses 10570 10558 -12
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (ø)` | |
| javascript | `63.84% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...feba3b0](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (6e1fc94) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `1.81%`.
> The diff coverage is `82.33%`.
> :exclamation: Current head 6e1fc94 differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 79.15% +1.81%
==========================================
Files 935 936 +1
Lines 47278 47408 +130
Branches 5883 5939 +56
==========================================
+ Hits 36564 37526 +962
+ Misses 10570 9755 -815
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <67.05%> (-0.03%)` | :arrow_down: |
| javascript | `68.53% <76.67%> (+4.78%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (62e9630) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
- Coverage 77.33% 76.84% -0.50%
==========================================
Files 935 939 +4
Lines 47278 47921 +643
Branches 5883 6139 +256
==========================================
+ Hits 36564 36824 +260
- Misses 10570 10954 +384
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.76% <ø> (-0.31%)` | :arrow_down: |
| javascript | `64.72% <ø> (+0.97%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-54.55%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.30% <0.00%> (-22.35%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `76.00% <0.00%> (-13.48%)` | :arrow_down: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `74.24% <0.00%> (-10.95%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `6.46% <0.00%> (-2.77%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <0.00%> (-1.38%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <0.00%> (-0.65%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...62e9630](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (62e9630) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `1.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
- Coverage 77.33% 76.31% -1.03%
==========================================
Files 935 951 +16
Lines 47278 48369 +1091
Branches 5883 6230 +347
==========================================
+ Hits 36564 36912 +348
- Misses 10570 11310 +740
- Partials 144 147 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.76% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.99% <0.00%> (-21.65%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `26.66% <0.00%> (-20.01%)` | :arrow_down: |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `32.00% <0.00%> (-18.00%)` | :arrow_down: |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | `71.42% <0.00%> (-14.29%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...62e9630](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (62e9630) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.49%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 62e9630 differs from pull request most recent head 65e0fb1. Consider uploading reports for the commit 65e0fb1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
- Coverage 77.33% 76.84% -0.50%
==========================================
Files 935 939 +4
Lines 47278 47921 +643
Branches 5883 6139 +256
==========================================
+ Hits 36564 36824 +260
- Misses 10570 10954 +384
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.76% <ø> (-0.31%)` | :arrow_down: |
| javascript | `64.72% <ø> (+0.97%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-54.55%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.30% <0.00%> (-22.35%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `76.00% <0.00%> (-13.48%)` | :arrow_down: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `74.24% <0.00%> (-10.95%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `6.46% <0.00%> (-2.77%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <0.00%> (-1.38%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <0.00%> (-0.65%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...65e0fb1](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (6e1fc94) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `1.81%`.
> The diff coverage is `82.33%`.
> :exclamation: Current head 6e1fc94 differs from pull request most recent head cbda5f9. Consider uploading reports for the commit cbda5f9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 79.15% +1.81%
==========================================
Files 935 936 +1
Lines 47278 47408 +130
Branches 5883 5939 +56
==========================================
+ Hits 36564 37526 +962
+ Misses 10570 9755 -815
+ Partials 144 127 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <67.05%> (-0.03%)` | :arrow_down: |
| javascript | `68.53% <76.67%> (+4.78%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...end/src/common/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duQnV0dG9uL2luZGV4LnRzeA==) | `24.00% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...cbda5f9](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (d9e3b50) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d9e3b50 differs from pull request most recent head 87f6da8. Consider uploading reports for the commit 87f6da8 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 77.36% +0.02%
==========================================
Files 935 935
Lines 47278 47278
Branches 5883 5883
==========================================
+ Hits 36564 36576 +12
+ Misses 10570 10558 -12
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (ø)` | |
| javascript | `63.84% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...87f6da8](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-816199178
@rusackas Ephemeral environment spinning up at http://54.190.184.95:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13860: test: ShareMenuItems
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13860:
URL: https://github.com/apache/superset/pull/13860#issuecomment-809841766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=h1) Report
> Merging [#13860](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=desc) (d9e3b50) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d9e3b50 differs from pull request most recent head 62e9630. Consider uploading reports for the commit 62e9630 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13860 +/- ##
==========================================
+ Coverage 77.33% 77.36% +0.02%
==========================================
Files 935 935
Lines 47278 47278
Branches 5883 5883
==========================================
+ Hits 36564 36576 +12
+ Misses 10570 10558 -12
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (ø)` | |
| javascript | `63.84% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13860/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=footer). Last update [84560e8...62e9630](https://codecov.io/gh/apache/superset/pull/13860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org