Re: [PR] fix(zset): wrong RESP reply in ZRANDMEMBER and ZMSCORE command [kvrocks]

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #2937:
URL: https://github.com/apache/kvrocks/pull/2937#discussion_r2077142663


##########
src/commands/cmd_zset.cc:
##########
@@ -1109,9 +1109,9 @@ class CommandZMScore : public Commander {
       for (const auto &member : members) {
         auto iter = mscores.find(member.ToString());
         if (iter == mscores.end()) {
-          values.emplace_back(conn->NilString());
+          values.emplace_back("");
         } else {
-          values.emplace_back(conn->Double(iter->second));
+          values.emplace_back(util::Float2String(iter->second));

Review Comment:
   We can replace `conn->MultiBulkString(values);` in 1118th line to `Array(values)` instead of changing here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org